Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-core): externalcjs resolve options #57645

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Oct 27, 2023

What

Probably not a big deal since we run this against cjs / esm both, but looks like it's a minor typo.

Closes WEB-1894

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Oct 27, 2023
@kwonoj kwonoj changed the title fix(next-core): externalcjs resolve options [WIP] fix(next-core): externalcjs resolve options Oct 27, 2023
@kwonoj kwonoj changed the title [WIP] fix(next-core): externalcjs resolve options fix(next-core): externalcjs resolve options Oct 27, 2023
@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js external-resolve-option Change
buildDuration 10.4s 10.4s N/A
buildDurationCached 6s 6.6s ⚠️ +618ms
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 420ms 422ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js external-resolve-option Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js external-resolve-option Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js external-resolve-option Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js external-resolve-option Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js external-resolve-option Change
index.html gzip 528 B 527 B N/A
link.html gzip 542 B 544 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js external-resolve-option Change
edge-ssr.js gzip 96.1 kB 96.2 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js external-resolve-option Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Commit: 626e0f6

@kwonoj kwonoj marked this pull request as ready for review October 27, 2023 22:08
wbinnssmith
wbinnssmith previously approved these changes Oct 31, 2023
jridgewell
jridgewell previously approved these changes Oct 31, 2023
sokra
sokra previously approved these changes Oct 31, 2023
@ijjk
Copy link
Member

ijjk commented Nov 1, 2023

Tests Passed

@kwonoj kwonoj dismissed stale reviews from sokra, wbinnssmith, and jridgewell via d297b1c November 1, 2023 16:41
@kwonoj kwonoj force-pushed the external-resolve-option branch 3 times, most recently from 660ea74 to fa67be9 Compare November 1, 2023 17:10
));
}

// When it's not resolveable as ESM, there is maybe an extension missing, try
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this logic be on the turbo side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but maybe. Since this is a plugin (ExternalCjsModulesResolvePlugin), we could reorg depends on the nature of the behavior.

@kodiakhq kodiakhq bot merged commit 555b131 into canary Nov 1, 2023
58 checks passed
@kodiakhq kodiakhq bot deleted the external-resolve-option branch November 1, 2023 19:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants