Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(next-api): remove unused distDir #57789

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Oct 31, 2023

What

recent define_env refactoring removed usage of separate distDir from project config.

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Oct 31, 2023
@ijjk
Copy link
Member

ijjk commented Oct 31, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js refactor-dist-dir Change
buildDuration 10.5s 10.5s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 430ms 422ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js refactor-dist-dir Change
199-HASH.js gzip 29.2 kB 29.3 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js refactor-dist-dir Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js refactor-dist-dir Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js refactor-dist-dir Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js refactor-dist-dir Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js refactor-dist-dir Change
edge-ssr.js gzip 92.2 kB 92.2 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js refactor-dist-dir Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 27.3 kB 27.3 kB
Next Runtimes
vercel/next.js canary vercel/next.js refactor-dist-dir Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 93.4 kB 93.4 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.8 kB 88.8 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 88.1 kB 88.1 kB
app-route-ex...dev.js gzip 23.5 kB 23.5 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 22.9 kB 22.9 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.2 kB 22.2 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 48.6 kB 48.6 kB
Overall change 920 kB 920 kB
Commit: 6107acf

@kwonoj kwonoj requested a review from a team as a code owner November 7, 2023 15:33
@ijjk
Copy link
Member

ijjk commented Nov 7, 2023

Tests Passed

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Hi there 👋

It looks like this PR introduces broken links to the docs, please take a moment to fix them before merging:

Broken link Type File
pages/building-your-application/rendering/incremental-static-regeneration related /docs/03-pages/01-building-your-application/02-rendering/05-client-side-rendering.mdx

Thank you 🙏

@kodiakhq kodiakhq bot merged commit f7b979c into canary Nov 8, 2023
53 of 59 checks passed
@kodiakhq kodiakhq bot deleted the refactor-dist-dir branch November 8, 2023 08:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants