Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the actionBrowser to RSC client layering issue #57842

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 31, 2023

You can read the removed comments to get some context here. Based on the community feedback, we're removing this compile-time error and instead, it will be a runtime error only when it gets accessed by React and found it missing in the manifest.

In the future, we'll need:

  • Converting the client references created this way to be specific errors. So they'll only throw in that certain case.
  • Or have a prepass compilation to collect all the references globally. This way we can support any kind of layer change.

Related: https://twitter.com/trashh_dev/status/1719016700191150550.

@ijjk
Copy link
Member

ijjk commented Oct 31, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js shu/6c13 Change
buildDuration 10.1s 10.2s N/A
buildDurationCached 5.8s 6.5s ⚠️ +765ms
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 397ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/6c13 Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/6c13 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js shu/6c13 Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js shu/6c13 Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/6c13 Change
index.html gzip 527 B 529 B N/A
link.html gzip 540 B 543 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js shu/6c13 Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js shu/6c13 Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 23 kB 23 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 25 kB 25 kB
Commit: 1338723

@kodiakhq kodiakhq bot merged commit 451ca9c into canary Oct 31, 2023
52 of 57 checks passed
@kodiakhq kodiakhq bot deleted the shu/6c13 branch October 31, 2023 23:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants