Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak postpone error copy & fix link #58219

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Nov 8, 2023

Fixes a broken link, shortens the title, and adds another possible way to resolve the error.

@ztanner ztanner marked this pull request as ready for review November 8, 2023 20:27
@ztanner ztanner requested review from ismaelrumzan and StephDietz and removed request for a team November 8, 2023 20:27
@ijjk
Copy link
Member

ijjk commented Nov 8, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
buildDuration 10.5s 10.3s N/A
buildDurationCached 6s 6.5s ⚠️ +544ms
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 418ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
199-HASH.js gzip 29.1 kB 29.1 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB N/A
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 46.9 kB 46.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 504 B 506 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.3 kB 4.3 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.65 kB 2.65 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
index.html gzip 529 B 529 B
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 529 B 529 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
edge-ssr.js gzip 92.5 kB 92.5 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/postpone-error-copy-tweaks Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.1 kB 93.1 kB N/A
app-page-tur..prod.js gzip 93.8 kB 93.8 kB N/A
app-page-tur..prod.js gzip 88.5 kB 88.5 kB N/A
app-page.run...dev.js gzip 137 kB 137 kB N/A
app-page.run..prod.js gzip 87.8 kB 87.8 kB N/A
app-route-ex...dev.js gzip 23.7 kB 23.7 kB
app-route-ex..prod.js gzip 16.3 kB 16.3 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route-tu..prod.js gzip 15.9 kB 15.9 kB
app-route.ru...dev.js gzip 23.1 kB 23.1 kB
app-route.ru..prod.js gzip 15.9 kB 15.9 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 48.8 kB 48.8 kB
Overall change 422 kB 422 kB
Diff details
Diff for page.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 519f040

@ijjk
Copy link
Member

ijjk commented Nov 8, 2023

Failing test suites

Commit: 519f040

pnpm test-dev test/e2e/app-dir/ppr/ppr.test.ts

  • ppr > should indicate the feature is experimental
Expand output

● ppr › should indicate the feature is experimental

expect(received).toContain(expected) // indexOf

Expected substring: "ppr"
Received string:    "yarn run v1.22.19
$ /tmp/next-install-9faafbd91d26472f59d750d26227128c28a0689887faf6865d4d457cc7a9d297/node_modules/.bin/next --turbo
   ▲ Next.js 14.0.2-canary.23 (turbo)
   - Local:        http://localhost:44949
   - Experiments (use at your own risk):
"

  10 |     it('should indicate the feature is experimental', () => {
  11 |       expect(next.cliOutput).toContain('Experiments (use at your own risk)')
> 12 |       expect(next.cliOutput).toContain('ppr')
     |                              ^
  13 |     })
  14 |     if (isNextStart) {
  15 |       describe('build output', () => {

  at Object.toContain (e2e/app-dir/ppr/ppr.test.ts:12:30)

Read more about building and testing Next.js in contributing.md.

@sebmarkbage sebmarkbage merged commit d422aeb into canary Nov 8, 2023
56 of 59 checks passed
@sebmarkbage sebmarkbage deleted the fix/postpone-error-copy-tweaks branch November 8, 2023 21:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants