Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cargo): bump up turbopack #64885

Closed
wants to merge 1 commit into from
Closed

build(cargo): bump up turbopack #64885

wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 22, 2024

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. type: next labels Apr 22, 2024
@ijjk
Copy link
Member

ijjk commented Apr 22, 2024 •
edited

Failing test suites

Commit: f4a711d

TURBOPACK=1 pnpm test-start test/production/app-dir-edge-runtime-with-wasm/index.test.ts (turbopack)

  • app-dir edge runtime with wasm > should have built
Expand output

● app-dir edge runtime with wasm › should have built

next build failed with code/signal 1

  89 |           if (code || signal)
  90 |             reject(
> 91 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  92 |             )
  93 |           else resolve()
  94 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:91:15)

● Test suite failed to run

TypeError: Cannot read properties of undefined (reading 'destroy')

  50 |     })
  51 |   })
> 52 |   afterAll(() => next.destroy())
     |                       ^
  53 |
  54 |   it('should have built', async () => {
  55 |     const html = await renderViaHTTP(next.url, '/')

  at Object.destroy (production/app-dir-edge-runtime-with-wasm/index.test.ts:52:23)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test test/integration/app-document-remove-hmr/test/index.test.js (turbopack)

  • _app removal HMR > should HMR when _app is removed
  • _app removal HMR > should HMR when _document is removed
Expand output

● _app removal HMR › should HMR when _app is removed

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__519fd9._.js" defer=""></script><script src="/_next/static/chunks/2c7be_react_3cd7ff._.js" defer=""></script><script src="/_next/static/chunks/4f707_react-dom_cjs_react-dom_development_c0b264.js" defer=""></script><script src="/_next/static/chunks/4f707_react-dom_55c180._.js" defer=""></script><script src="/_next/static/chunks/08b5e__pnpm_7e8b6b._.js" defer=""></script><script src="/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_7758ae._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_082867._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_fd73de._.js" defer=""></script><script src="/_next/static/chunks/%5Broot%20of%20the%20server%5D__bc93b8._.js" defer=""></script><script src="/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_748c4e._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_19f94b._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_8d8ef4._.js" defer=""></script><script src="/_next/static/development/_ssgManifest.js" defer=""></script><script src="/_next/static/development/_buildManifest.js" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><p>custom _document</p><div id="__next"><p>custom _app</p><p>index page</p></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><div id="__next-build-watcher" style="position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;"></div><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

undefined

  642 |
  643 |   if (hardError) {
> 644 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  645 |   }
  646 |   return false
  647 | }

  at check (lib/next-test-utils.ts:644:11)
  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:33:7)

● _app removal HMR › should HMR when _document is removed

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  73 |   })
  74 |
> 75 |   it('should HMR when _document is removed', async () => {
     |   ^
  76 |     let indexContent = await fs.readFile(indexPage)
  77 |     try {
  78 |       const browser = await webdriver(appPort, '/')

  at it (integration/app-document-remove-hmr/test/index.test.js:75:3)
  at Object.describe (integration/app-document-remove-hmr/test/index.test.js:16:1)

Read more about building and testing Next.js in contributing.md.

@kwonoj kwonoj closed this Apr 22, 2024
@kwonoj kwonoj deleted the bump-turbopack branch April 22, 2024 20:27
@github-actions github-actions bot added the locked label May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@ztanner ztanner Awaiting requested review from ztanner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwonoj @ijjk @wbinnssmith