Set default stale-while-revalidate header value to 1 year #65867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flybayer
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
feedthejim
approved these changes
May 16, 2024
panteliselef
pushed a commit
to panteliselef/next.js
that referenced
this pull request
May 20, 2024
ijjk
added a commit
that referenced
this pull request
May 23, 2024
Alternative to #65867 this stabilizes our `swrDelta` config that allows customizing the `stale-while-revalidate` period that is included in the `Cache-Control` header for ISR enabled routes. This is not a breaking change itself as no default value is provided as is the case already.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows 2 previous PRs, #52251 and #61330 by making a 1 year expiry the default for the
stale-while-revalidateheader.As far as I can tell, the current default is invalid according to RFC 5861.
Any user deploying Next.js behind any CDN other Vercel expects SWR to work correctly, but it does not because there is no default expiry value.
This change will make the default work for all Next.js users and greatly reduce frustration for those of us deploying Next.js places besides Vercel.
This also fixes a small edge case where
experimental.swrDelta = 0would not function as expected.Thank you!