Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image.mdx #66618

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update image.mdx #66618

merged 2 commits into from
Jun 6, 2024

Conversation

chrisjstott
Copy link
Contributor

Using overflow: hidden on the image's parent element is not necessary, as the image is already set to be the same dimensions as its parent with no overflow, and object-fit only changes the image aspect ratio & crop within those dimensions.

@chrisjstott chrisjstott requested review from molebox and StephDietz and removed request for a team June 6, 2024 22:46
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 6, 2024
@ijjk
Copy link
Member

ijjk commented Jun 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2177635

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

2 similar comments
@ijjk
Copy link
Member

ijjk commented Jun 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2177635

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jun 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 2177635

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@styfle styfle enabled auto-merge (squash) June 6, 2024 23:20
@styfle styfle merged commit a1eead8 into vercel:canary Jun 6, 2024
33 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants