Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling for invalid pages during autoExport #7574

Merged
merged 4 commits into from
Jun 14, 2019
Merged

Add handling for invalid pages during autoExport #7574

merged 4 commits into from
Jun 14, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 13, 2019

This catches and gives a descriptive error when a user doesn't export a valid component from a page with autoExport enabled

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 14.8s 15.1s ⚠️ +241ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +855 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 793 kB 793 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 15.4s 15.5s ⚠️ +78ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +855 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.3 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.9 kB 84.9 kB ⚠️ +1 B
Serverless pages/_error Size 331 kB 331 kB ✓
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ⚠️ +1 B
Serverless pages/routerDirect Size 332 kB 332 kB ✓
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB ✓
Serverless pages/withRouter Size 332 kB 332 kB ✓
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ✓
Build Dir Size 2.29 MB 2.29 MB ✓

@ijjk ijjk requested a review from timneutkens June 13, 2019 23:25
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 14.8s 14.7s -74ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 793 kB 793 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 15.3s 15.3s -5ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.4 kB 87.4 kB ✓
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.9 kB 84.9 kB ✓
Serverless pages/_error Size 331 kB 331 kB ✓
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ✓
Serverless pages/routerDirect Size 332 kB 332 kB ✓
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB -1 B
Serverless pages/withRouter Size 332 kB 332 kB ✓
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ✓
Build Dir Size 2.29 MB 2.29 MB ✓

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 14.9s 14.6s -303ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 793 kB 793 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 15.1s 15.3s ⚠️ +209ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.4 kB 87.4 kB -1 B
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.9 kB 84.9 kB -1 B
Serverless pages/_error Size 331 kB 331 kB ✓
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ✓
Serverless pages/routerDirect Size 332 kB 332 kB ✓
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB -2 B
Serverless pages/withRouter Size 332 kB 332 kB ✓
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB -1 B
Build Dir Size 2.29 MB 2.29 MB ✓

@ijjk @timneutkens
Apply suggestions from code review
ed0aa7a 
Co-Authored-By: Tim Neutkens <tim@timneutkens.nl>
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 15s 14.7s -337ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 222 B 222 B ✓
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ✓
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Base Rendered Size 1.34 kB 1.34 kB ✓
Build Dir Size 793 kB 793 kB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js fix/invalid-page-handling Change
Build Duration 15.4s 15.2s -184ms
node_modules Size 41.2 MB 41.2 MB ⚠️ +1.03 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB ✓
Total Bundle (main, webpack, commons) gzip Size 68.9 kB 68.9 kB -1 B
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _error Size 8.8 kB 8.8 kB ✓
Client _error gzip Size 3.32 kB 3.32 kB ✓
Client pages/index Size 296 B 296 B ✓
Client pages/index gzip Size 224 B 222 B -2 B
Client pages/link Size 4.85 kB 4.85 kB ✓
Client pages/link gzip Size 2.07 kB 2.07 kB ⚠️ +1 B
Client pages/routerDirect Size 411 B 411 B ✓
Client pages/routerDirect gzip Size 296 B 296 B ✓
Client pages/withRouter Size 393 B 393 B ✓
Client pages/withRouter gzip Size 280 B 280 B ✓
Client main Size 24.3 kB 24.3 kB ✓
Client main gzip Size 7.98 kB 7.98 kB ✓
Client commons Size 183 kB 183 kB ✓
Client commons gzip Size 59.6 kB 59.6 kB ✓
Client webpack Size 1.49 kB 1.49 kB ✓
Client webpack gzip Size 770 B 770 B ✓
Serverless pages/link Size 340 kB 340 kB ✓
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 331 kB 331 kB ✓
Serverless pages/index gzip Size 84.9 kB 84.9 kB ⚠️ +3 B
Serverless pages/_error Size 331 kB 331 kB ✓
Serverless pages/_error gzip Size 84.6 kB 84.6 kB ⚠️ +3 B
Serverless pages/routerDirect Size 332 kB 332 kB ✓
Serverless pages/routerDirect gzip Size 84.9 kB 84.9 kB ⚠️ +4 B
Serverless pages/withRouter Size 332 kB 332 kB ✓
Serverless pages/withRouter gzip Size 84.8 kB 84.8 kB ⚠️ +2 B
Build Dir Size 2.29 MB 2.29 MB ✓

@ijjk ijjk merged commit 090a06b into vercel:canary Jun 14, 2019
@ijjk ijjk deleted the fix/invalid-page-handling branch June 14, 2019 00:08
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@dav-is dav-is Awaiting requested review from dav-is

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens