Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config/test app for new PR stats set-up #8317

Merged
merged 3 commits into from
Aug 11, 2019
Merged

Add config/test app for new PR stats set-up #8317

merged 3 commits into from
Aug 11, 2019

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 10, 2019

This moves the test app and configuration out into the Next.js repository for easier updating/tweaking.

When running for a PR the configuration/test app in the PR branch will be used allowing to compare new features/stats before merging separately.

Since the config is also broken out from the stats app it makes it easier to use to analyze other projects.

x-ref: https://github.com/zeit/next-stats-action/pull/1

@ijjk
Copy link
Member Author

ijjk commented Aug 10, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js add/stats-config Change
Build Duration 21.8s 21.9s ⚠️ +123ms
node_modules Size 41.6 MB 41.6 MB ✓
Total Bundle (main, webpack, commons) Size 214 kB 214 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.6 kB 70.6 kB ✓
Total Bundle (main, webpack, commons) Modern Size 189 kB 189 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 62.4 kB 62.4 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.18 kB 4.18 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/link Modern Size 3.81 kB 3.81 kB ✓
Client pages/link gzip Modern Size 1.72 kB 1.72 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 16.3 kB 16.3 kB ✓
Client main gzip Size 5.73 kB 5.73 kB ✓
Client main Modern Size 13.1 kB 13.1 kB ✓
Client main Modern gzip Size 4.99 kB 4.99 kB ✓
Client commons Size 195 kB 195 kB ✓
Client commons gzip Size 63.6 kB 63.6 kB ✓
Client commons Modern Size 176 kB 176 kB ✓
Client commons Modern gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Base Rendered Size 2.76 kB 2.76 kB ✓
Build Dir Size 1.44 MB 1.44 MB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js add/stats-config Change
Build Duration 23.3s 23.5s ⚠️ +218ms
node_modules Size 41.6 MB 41.6 MB ✓
Total Bundle (main, webpack, commons) Size 214 kB 214 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.6 kB 70.6 kB ✓
Total Bundle (main, webpack, commons) Modern Size 189 kB 189 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 62.4 kB 62.4 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.18 kB 4.18 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/link Modern Size 3.81 kB 3.81 kB ✓
Client pages/link gzip Modern Size 1.72 kB 1.72 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 16.3 kB 16.3 kB ✓
Client main gzip Size 5.73 kB 5.73 kB ✓
Client main Modern Size 13.1 kB 13.1 kB ✓
Client main Modern gzip Size 4.99 kB 4.99 kB ✓
Client commons Size 195 kB 195 kB ✓
Client commons gzip Size 63.6 kB 63.6 kB ✓
Client commons Modern Size 176 kB 176 kB ✓
Client commons Modern gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Serverless pages/link Size 256 kB 256 kB ✓
Serverless pages/link gzip Size 68.8 kB 68.8 kB ✓
Serverless pages/index Size 249 kB 249 kB ✓
Serverless pages/index gzip Size 66.6 kB 66.6 kB ✓
Serverless pages/_error Size 248 kB 248 kB ✓
Serverless pages/_error gzip Size 66.3 kB 66.3 kB ✓
Serverless pages/routerDirect Size 249 kB 249 kB ✓
Serverless pages/routerDirect gzip Size 66.5 kB 66.5 kB ✓
Serverless pages/withRouter Size 249 kB 249 kB ✓
Serverless pages/withRouter gzip Size 66.6 kB 66.6 kB ✓
Build Dir Size 2.65 MB 2.65 MB ✓

@timneutkens
Copy link
Member

Can it be inside the test directory?

@ijjk
Copy link
Member Author

ijjk commented Aug 11, 2019

Yeah, updated it to be in the test folder

@ijjk
Copy link
Member Author

ijjk commented Aug 11, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary ijjk/next.js add/stats-config Change
Build Duration 22.5s 22.7s ⚠️ +170ms
node_modules Size 41.6 MB 41.6 MB ✓
Total Bundle (main, webpack, commons) Size 214 kB 214 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.6 kB 70.6 kB ⚠️ +1 B
Total Bundle (main, webpack, commons) Modern Size 189 kB 189 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 62.4 kB 62.4 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ⚠️ +1 B
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.18 kB 4.18 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/link Modern Size 3.81 kB 3.81 kB ✓
Client pages/link gzip Modern Size 1.72 kB 1.72 kB ⚠️ +1 B
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 300 B 301 B ⚠️ +1 B
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 16.3 kB 16.3 kB ✓
Client main gzip Size 5.73 kB 5.73 kB ✓
Client main Modern Size 13.1 kB 13.1 kB ✓
Client main Modern gzip Size 4.99 kB 4.99 kB ✓
Client commons Size 195 kB 195 kB ✓
Client commons gzip Size 63.6 kB 63.6 kB ✓
Client commons Modern Size 176 kB 176 kB ✓
Client commons Modern gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Base Rendered Size 2.76 kB 2.76 kB ✓
Build Dir Size 1.44 MB 1.44 MB ✓
Click to expand serverless stats
zeit/next.js canary ijjk/next.js add/stats-config Change
Build Duration 24.7s 24.7s ⚠️ +1ms
node_modules Size 41.6 MB 41.6 MB ✓
Total Bundle (main, webpack, commons) Size 214 kB 214 kB ✓
Total Bundle (main, webpack, commons) gzip Size 70.6 kB 70.6 kB ✓
Total Bundle (main, webpack, commons) Modern Size 189 kB 189 kB ✓
Total Bundle (main, webpack, commons) Modern gzip Size 62.4 kB 62.4 kB ✓
Client _app Size 2.39 kB 2.39 kB ✓
Client _app gzip Size 1.08 kB 1.08 kB ✓
Client _app Modern Size 1.83 kB 1.83 kB ✓
Client _app gzip Modern Size 890 B 890 B ✓
Client _error Size 8.22 kB 8.22 kB ✓
Client _error gzip Size 3.16 kB 3.16 kB ✓
Client _error Modern Size 5.85 kB 5.85 kB ✓
Client _error gzip Modern Size 2.33 kB 2.33 kB ✓
Client pages/index Size 343 B 343 B ✓
Client pages/index gzip Size 246 B 246 B ✓
Client pages/index Modern Size 319 B 319 B ✓
Client pages/index gzip Modern Size 254 B 254 B ✓
Client pages/link Size 4.18 kB 4.18 kB ✓
Client pages/link gzip Size 1.82 kB 1.82 kB ✓
Client pages/link Modern Size 3.81 kB 3.81 kB ✓
Client pages/link gzip Modern Size 1.72 kB 1.72 kB ✓
Client pages/routerDirect Size 423 B 423 B ✓
Client pages/routerDirect gzip Size 306 B 306 B ✓
Client pages/routerDirect Modern Size 411 B 411 B ✓
Client pages/routerDirect gzip Modern Size 314 B 314 B ✓
Client pages/withRouter Size 435 B 435 B ✓
Client pages/withRouter gzip Size 301 B 301 B ✓
Client pages/withRouter Modern Size 423 B 423 B ✓
Client pages/withRouter gzip Modern Size 309 B 309 B ✓
Client main Size 16.3 kB 16.3 kB ✓
Client main gzip Size 5.73 kB 5.73 kB ✓
Client main Modern Size 13.1 kB 13.1 kB ✓
Client main Modern gzip Size 4.99 kB 4.99 kB ✓
Client commons Size 195 kB 195 kB ✓
Client commons gzip Size 63.6 kB 63.6 kB ✓
Client commons Modern Size 176 kB 176 kB ✓
Client commons Modern gzip Size 57.4 kB 57.4 kB ✓
Client webpack Size 1.53 kB 1.53 kB ✓
Client webpack gzip Size 778 B 778 B ✓
Client webpack Modern Size 1.53 kB 1.53 kB ✓
Client webpack Modern gzip Size 785 B 785 B ✓
Serverless pages/link Size 256 kB 256 kB ✓
Serverless pages/link gzip Size 68.8 kB 68.8 kB ⚠️ +1 B
Serverless pages/index Size 249 kB 249 kB ✓
Serverless pages/index gzip Size 66.6 kB 66.6 kB ⚠️ +1 B
Serverless pages/_error Size 248 kB 248 kB ✓
Serverless pages/_error gzip Size 66.3 kB 66.3 kB ⚠️ +2 B
Serverless pages/routerDirect Size 249 kB 249 kB ✓
Serverless pages/routerDirect gzip Size 66.5 kB 66.5 kB ⚠️ +2 B
Serverless pages/withRouter Size 249 kB 249 kB ✓
Serverless pages/withRouter gzip Size 66.6 kB 66.6 kB ⚠️ +2 B
Build Dir Size 2.65 MB 2.65 MB ✓

@timneutkens timneutkens merged commit f01af7c into vercel:canary Aug 11, 2019
@ijjk ijjk deleted the add/stats-config branch August 12, 2019 14:36
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens