Prevents externalizing non-hoisted packages #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
requested review from
ijjk,
lfades,
Timer and
timneutkens
as code owners
Timer
approved these changes
Sep 14, 2019
|
Awesome, it is working again!!! The last working version was 9.0.6-canary.1. |
|
@gurkerl83 just to confirm, it should be working on |
|
@Timer it does work with v9.0.6-canary.4. |
This was referenced Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff ensures that the packages that wouldn't get the correct resolution if required from the root are properly bundled (and thus don't risk requiring the wrong files if they were loaded at runtime via
require).Tested manually, it solved the
core-jserror I previously saw.Fixes #8736