Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify useRouter isn't null for serverless modes #8740

Closed
wants to merge 1 commit into from
Closed

Verify useRouter isn't null for serverless modes #8740

wants to merge 1 commit into from

Conversation

Timer
Copy link
Member

@Timer Timer commented Sep 14, 2019

This test should fail until #8739 is merged.

@Timer Timer added this to the 9.0.6 milestone Sep 14, 2019
@ijjk
Copy link
Member

ijjk commented Sep 14, 2019

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js verify-next-usage Change
buildDuration 16.2s 16.6s ⚠️ +319ms
nodeModulesSize 42 MB 42 MB -151 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js verify-next-usage Change
main-HASH.js 18.2 kB 18.2 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB ✓
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js verify-next-usage Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.4 kB 6.4 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary Timer/next.js verify-next-usage Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.11 kB 8.11 kB ✓
link.js gzip 3.48 kB 3.48 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js verify-next-usage Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.5 kB 8.5 kB ✓
link.module.js gzip 3.66 kB 3.66 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js verify-next-usage Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js verify-next-usage Change
index.html 3.62 kB 3.62 kB ✓
index.html gzip 948 B 948 B ✓
link.html 3.66 kB 3.66 kB ✓
link.html gzip 955 B 955 B ✓
withRouter.html 3.67 kB 3.67 kB ✓
withRouter.html gzip 943 B 943 B ✓
Overall change 10.9 kB 10.9 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary Timer/next.js verify-next-usage Change
buildDuration 16.4s 16.9s ⚠️ +555ms
nodeModulesSize 42 MB 42 MB -151 B
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js verify-next-usage Change
main-HASH.js 18.2 kB 18.2 kB ✓
main-HASH.js gzip 6.66 kB 6.66 kB ✓
webpack-HASH.js 1.53 kB 1.53 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..2b8407376.js 21.9 kB 21.9 kB ✓
4952ddcd88e7..7376.js gzip 7.81 kB 7.81 kB ✓
de003c3a9d30..1c5d17695.js 43.1 kB 43.1 kB ✓
de003c3a9d30..7695.js gzip 15.4 kB 15.4 kB ✓
framework.5b..dbaff70d3.js 125 kB 125 kB ✓
framework.5b..70d3.js gzip 39.4 kB 39.4 kB ✓
Overall change 210 kB 210 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js verify-next-usage Change
main-HASH.module.js 16.6 kB 16.6 kB ✓
main-HASH.module.js gzip 6.4 kB 6.4 kB ✓
webpack-HASH.module.js 1.53 kB 1.53 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..5f.module.js 45.5 kB 45.5 kB ✓
de003c3a9d30..dule.js gzip 16.5 kB 16.5 kB ✓
framework.5b..d3.module.js 125 kB 125 kB ✓
framework.5b..dule.js gzip 39.4 kB 39.4 kB ✓
Overall change 189 kB 189 kB ✓
Client Pages
zeit/next.js canary Timer/next.js verify-next-usage Change
_app.js 1.81 kB 1.81 kB ✓
_app.js gzip 873 B 873 B ✓
_error.js 12 kB 12 kB ✓
_error.js gzip 4.73 kB 4.73 kB ✓
hooks.js 12.7 kB 12.7 kB ✓
hooks.js gzip 4.79 kB 4.79 kB ✓
index.js 318 B 318 B ✓
index.js gzip 222 B 222 B ✓
link.js 8.11 kB 8.11 kB ✓
link.js gzip 3.48 kB 3.48 kB ✓
routerDirect.js 408 B 408 B ✓
routerDirect.js gzip 281 B 281 B ✓
withRouter.js 419 B 419 B ✓
withRouter.js gzip 280 B 280 B ✓
Overall change 35.8 kB 35.8 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js verify-next-usage Change
_app.module.js 1.7 kB 1.7 kB ✓
_app.module.js gzip 832 B 832 B ✓
_error.module.js 23.3 kB 23.3 kB ✓
_error.module.js gzip 8.59 kB 8.59 kB ✓
hooks.module.js 1.52 kB 1.52 kB ✓
hooks.module.js gzip 793 B 793 B ✓
index.module.js 294 B 294 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js 8.5 kB 8.5 kB ✓
link.module.js gzip 3.66 kB 3.66 kB ✓
routerDirect.module.js 394 B 394 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.module.js 404 B 404 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 36.1 kB 36.1 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js verify-next-usage Change
_buildManifest.js 81 B 81 B ✓
_buildManifest.js gzip 61 B 61 B ✓
_buildManifest.module.js 81 B 81 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 162 B 162 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js verify-next-usage Change
_error.js 248 kB 248 kB ✓
_error.js gzip 66.2 kB 66.2 kB ✓
hooks.html 3.73 kB 3.73 kB ✓
hooks.html gzip 974 B 974 B ✓
index.js 248 kB 248 kB ✓
index.js gzip 66.5 kB 66.5 kB ✓
link.js 255 kB 255 kB ✓
link.js gzip 68.5 kB 68.5 kB ✓
routerDirect.js 249 kB 249 kB ✓
routerDirect.js gzip 66.5 kB 66.5 kB ✓
withRouter.js 249 kB 249 kB ✓
withRouter.js gzip 66.6 kB 66.6 kB ✓
Overall change 1.25 MB 1.25 MB ✓

Commit: 03d9a91

@Timer
Copy link
Member Author

Timer commented Sep 14, 2019

Weeelp, I guess this test doesn't work correct.

@Timer Timer closed this Sep 14, 2019
@Timer Timer deleted the verify-next-usage branch September 14, 2019 20:01
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Timer @ijjk