infinite: do not revalidate every page on mutate(undefined)

[hazae41]

Bug report

Description / Observed Behavior

When I use .mutate(), all pages are revalidated even tough nothing changed in the first page, and the keys didn't change

This behaviour happens regardless of revalidateIfStale, and regardless of the new revalidateFirstPage

Expected Behavior

Do not revalidate if the first page is the same and keys are the same

Repro Steps / Code Example

const key = useCallback((page: number, previous: Data | null) => {
  // First page
  if (page === 0 || !previous)
    return h(`topics`) // h is just a query builder
  // No next page
  if (!previous.after)
    return null
  // Next page
  const [after] = previous.after
  return h(`topics`, { after })
}, [])

const res = useSWRInfinite<Data>(key, fetcher, {})

const refresh = useCallback(() => {
  res.mutate()
}, [res])

return <button onClick={refresh}>
  refresh
</button>

Additional Context

happening on both swr@1.0.1 and swr@1.1.0-beta.6

[hazae41]

This also happens on automatic revalidation

[hazae41]

Ok, this comes to the fact that mutate() becomes mutate(undefined)

Fix is:

const refresh = useCallback(() => {
  res.mutate(d => d, true)
}, [res.mutate])

[hazae41]

Still happens on beta 8, all pages are revalidated when doing mutate(undefined)

const refresh = useCallback(() => {
  res.mutate(d => d, true)
}, [res.mutate])

[shuding]

Very weird, let me try to reproduce this.

[shuding]

If you call res.mutate(), everything will be revalidated. That's currently the expected behavior:

swr/infinite/index.ts

Lines 190 to 191 in e167752

	// Calling `mutate()`, we revalidate all pages
	cache.set(contextCacheKey, [true])

We need to improve the local mutation API for pages a bit.

[iDarkLightning]

Hi!

Have there been any updates regarding this issue? I'd like to be able to mutate & revalidate a specified page, and not all the loaded pages when calling mutate(). Is this possible in any way with the current implementation?

[misa-minic]

Hi!
Any updates regarding this issue?

[hazae41]

If you find this annoying, you can use my library

https://github.com/hazae41/xswr

You can revalidate any single page without revalidating everything

[misa-minic]

I have to use SWR only, but I found some work around. Thanks!

[khanhld1910]

hi @misa-minic could you share your solution? I thought about storing all items into a useState and then modifying a specific item after it's updated but I feel there should be a better solution

[misa-minic]

Hi @khanhld1910
Sorry for the late reply, I hope you found the solution by now.

If not, take a look at:
https://swr.vercel.app/docs/mutation.en-US#mutate-multiple-items

You should be able with mutate to update only a certain KEY which represents each api call/url for getting a next "page" of items.
In my case, I find the index of the item I updated e.g. index 15, then I could say, refetch only 10 items, from index 10 to index 20. This way I am not updating all the fetched items, but only 10 among which is my updated item.

Let me know if you need some info.