refactor: switch to useSyncExternalStoreWithSelector #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade to jest 28 * Upgrade to jest 28
promer94
changed the title
state update should be handled by uSESW
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f23117b:
|
|
This would not be an appropriate place to ask, but currently SWR stores some information like a current key and store into Should SWR migrate the usage of useRef objects like this PR does, or is it safe as long as |
As far as i know, updating ref in effect is concurrent safe. |
promer94
changed the title
promer94
changed the title
huozhi
reviewed
May 12, 2022
| @@ -37,7 +37,7 @@ describe('useSWR - error', () => { | |||
| { onError: (_, errorKey) => (erroredSWR = errorKey) } | |||
| ) | |||
| if (error) return <div>{error.message}</div> | |||
| return <div>hello, {data}</div> | |||
| return <div><>hello, {data}</></div> | |||
There was a problem hiding this comment.
Because the data is infered as Error here.
huozhi
reviewed
May 12, 2022
shuding
approved these changes
May 13, 2022
promer94
added a commit
to promer94/swr
that referenced
this pull request
May 13, 2022
* type: extends useConfig cache interface (vercel#1938) * remove mount check for react18 (vercel#1927) reactwg/react-18#82 related pr vercel#787 vercel#433 * lint: dont check unused vars with underscore prefix (vercel#1939) * test: upgrade to jest 28 (vercel#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im>
shuding
added a commit
that referenced
this pull request
May 13, 2022
* update state in a transition * support snapshotting external state * wip * move types:check to pre-commit * refactor: switch to useSyncExternalStoreWithSelector (#1953) * type: extends useConfig cache interface (#1938) * remove mount check for react18 (#1927) reactwg/react-18#82 related pr #787 #433 * lint: dont check unused vars with underscore prefix (#1939) * test: upgrade to jest 28 (#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im> * chore: useSES should be external (#1960) * rename type * types: update cache types * chore: move @types/useSES to devDependencies Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intented to solve the 'tearing' problem described in #794 for React 18.
Example for 'tearing' in React 18: https://codesandbox.io/s/concurrent-swr-case-iii-shu-s5fggt
It will also solve the cache initialization problem in StrictMode
#1904 https://codesandbox.io/s/swr-1904-mxfft8
#1949 https://codesandbox.io/s/swr-1949-22d6iw
limitations
Accroding to the useSES RFC
examples:
https://codesandbox.io/s/concurrent-swr-case-i-shu-dckwqj
https://codesandbox.io/s/concurrent-swr-case-ii-shu-3j5j2e