fix: do mount check in config callback #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promer94
requested review from
pacocoursey,
shuding and
Timer
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8ab121a:
|
shuding
added a commit
that referenced
this pull request
Dec 16, 2020
* 0.3.8 * replace rIC with rAF (#744) * Fix race condition when calling mutate synchronously (#735) * fix race condition when calling mutate synchronously * fix test * add comment * fix code reviews * refactor: support SSR in Deno (#754) * refactor: support SSR in Deno * refactor: improve Deno determining * Add @ts-ignore Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: Shu Ding <g@shud.in> * fix eslint error (#768) * Fix `mutateCallback` types (#745) * Fix `mutateCallback` types * WIP * Add CodeSandbox CI (#769) * add CodeSandbox CI * add new line * fix install cmd Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com> * dispatch's payload type is actionType and run lint (#772) * chore: payload is actionType * chore: move a ts-ignore comment * Fix suspense (#777) * fix #494 * add comment * rename to initialMountedRef * 0.3.9 * fix: mark isValidating as false when key is falsy (#757) * fix: tear down when key turns to empty * use false for empty key * Fix README.md typo (#783) '/api/data' => '/api/user' in "Multiple Arguments" * fix: do mount check in config callback (#787) * Update api-hooks example README.md (#790) Updated the Vercel deploy link to the correct directory * Return '@null' if args is null ASAP (#767) * chore: return 'null' if arg[i] is null ASAP * chore: update comment * chore: use continue * Bump ini from 1.3.5 to 1.3.8 (#806) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update test Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: X <git@iamje.com> Co-authored-by: Umidbek Karimov <uma.karimov@gmail.com> Co-authored-by: Paco <34928425+pacocoursey@users.noreply.github.com> Co-authored-by: matamatanot <39780486+matamatanot@users.noreply.github.com> Co-authored-by: Jiachi Liu <inbox@huozhi.im> Co-authored-by: sAy <47605337+mingcenwei@users.noreply.github.com> Co-authored-by: William Crutchfield <william.r.crutchfield@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
promer94
added a commit
to promer94/swr
that referenced
this pull request
Apr 16, 2022
promer94
added a commit
to promer94/swr
that referenced
this pull request
Apr 17, 2022
promer94
added a commit
to promer94/swr
that referenced
this pull request
Apr 20, 2022
shuding
pushed a commit
that referenced
this pull request
Apr 20, 2022
himanshiLt
pushed a commit
to himanshiLt/swr
that referenced
this pull request
Apr 26, 2022
shuding
pushed a commit
that referenced
this pull request
May 13, 2022
* type: extends useConfig cache interface (#1938) * remove mount check for react18 (#1927) reactwg/react-18#82 related pr #787 #433 * lint: dont check unused vars with underscore prefix (#1939) * test: upgrade to jest 28 (#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im>
promer94
added a commit
to promer94/swr
that referenced
this pull request
May 13, 2022
* type: extends useConfig cache interface (vercel#1938) * remove mount check for react18 (vercel#1927) reactwg/react-18#82 related pr vercel#787 vercel#433 * lint: dont check unused vars with underscore prefix (vercel#1939) * test: upgrade to jest 28 (vercel#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im>
shuding
added a commit
that referenced
this pull request
May 13, 2022
* update state in a transition * support snapshotting external state * wip * move types:check to pre-commit * refactor: switch to useSyncExternalStoreWithSelector (#1953) * type: extends useConfig cache interface (#1938) * remove mount check for react18 (#1927) reactwg/react-18#82 related pr #787 #433 * lint: dont check unused vars with underscore prefix (#1939) * test: upgrade to jest 28 (#1942) * Upgrade to jest 28 * Upgrade to jest 28 * feat: useSyncExternalStoreWithSelector * refactor: remove stateUpdate and boardcast state update should be handled by uSESW * type: fix test type error * remove pnpm.lock * fix: import cjs for codesanbox * refactor: add selector * refactor: add cachestate interface and try fix custom cache * fix: custom cache init * refactor: remove useless flag * chore: codesanbox ci * refactor: remove force render in infinite * build: add _internal * chore: mark warning test * fix: dts generation * codesanbox ci * chore: rename swr folder to core Co-authored-by: Jiachi Liu <inbox@huozhi.im> * chore: useSES should be external (#1960) * rename type * types: update cache types * chore: move @types/useSES to devDependencies Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Observed Behavior
config callback may also cause
Can't perform a React state update on a component that hasn't mounted yetRepro Steps / Code Example
Repo