Does turbo support negative globs for turbo.json task inputs?

[zaripych]

E.g. in CRA apps tests are in src/** directory and should not affect build.

    "build": {
      "dependsOn": [],
      "inputs": [
        "src/**/*.ts",
        "src/**/*.tsx"
      ],
      "outputs": ["dist"]
    }

I've tried to use negative patterns: !src/**/__tests__ and !src/**/*.test.ts ... but they don't seem to be effective and changes in tests cause build task hash to change. I've tried putting them in different order with no luck. There is a brief mention of negative globs for --ignore parameter of the CLI ... but I don't think it works here.

[zaripych]

Looks like negative globs are not supported for inputs as per

turborepo/cli/internal/taskhash/taskhash.go

Line 124 in cfb65cb

val, err := doublestar.PathMatch(includePattern, name)

Would it be a terrible idea to add support? To me it seems like we could be something simple in manuallyHashPackage that would use inputs where globs start with ! as ignore patterns.

[zaripych]

I looked at git ls-files pathway of hash computation as well (it would require git style negation using :!:) and have a small POC working. Let me know if this is worth a PR.

[weyert]

Off topic, but do you have link about :!:?

[zaripych]

Here we go https://stackoverflow.com/questions/36753573/how-do-i-exclude-files-from-git-ls-files

[zaripych]

And the fork zaripych@4b3d7bb - same changes on top of latest stable version of turborepo seemed to work for me locally, but obviously needs more unit tests ...

[weyert]

Fascinating never remotely thought of/would have tried :!: :)
Thanks for the fork. I still haven’t cracked the problem of getting turbo binaries of forks to CI

[nathanhammond]

Officially, no, we don't support it. However, if you trace through certain places in the codebase, you will see that our glob handling is inconsistent and you can probably sneak them in. I don't recommend it as the availability is incidental, but because we are as frustrated as we are with our existing setup it is on our list to rework. Feature request received. 😊

[jkjustjoshing]

@nathanhammond what's the status of this? Why was this closed?

[jkjustjoshing]

According to #4066, this has been implemented? However there's no documentation around it. https://turbo.build/repo/docs/reference/configuration#inputs should have a mention of the support, or at least an example in one of the inputs arrays.