Turbo crashes after deleting yarn.lock or update #6715
Assignees
Labels
Comments
FrancoRATOVOSON
added
kind: bug
|
Hi @FrancoRATOVOSON, thanks for the issue. Could you try with the |
|
@FrancoRATOVOSON I noticed in the repro you linked that you're using Yarn 4 which we don't officially support yet. Could you try using Yarn 3, regenerating the |
|
@FrancoRATOVOSON We still need to solve the panic, but I believe you want to change |
|
Saw this and I fixed it but nothing changed |
Yarn 4 was the problem, so we can now rename this issue as "support yarn 4" 😅 |
|
Seems like this happens with |
chris-olszewski
added a commit
that referenced
this issue
Jan 2, 2024
### Description Fixes #6715 Yarn 4 now makes the default protocol of `npm` (e.g. `"foo": "*"` is really `"foo": "npm:*"`) explicit in the lockfile representation. This means that workspaces that reference a package with and without a protocol will end up with multiple protocols for a single descriptor. e.g. If one package has a dependency `"c": "*"` and another package in the workspace has a dependency `"c": "workspace:*"` In Yarn3 those result in the following descriptors: `c@*, c@workspace:*, c@workspace:pkgs/c` In Yarn4 those result in the following descriptors: `c@npm:*, c@workspace:*, c@workspace:pkgs/c` We cannot get rid of the logic for case without a protocol as that would break our Yarn3 usage. ### Testing Instructions Added unit test that has a lockfile with mixed protocols. Existing unit tests verify the Yarn3 behavior is still supported. Closes TURBO-1856 Co-authored-by: Chris Olszewski <Chris Olszewski>
Zertsov
pushed a commit
that referenced
this issue
Jan 5, 2024
### Description Fixes #6715 Yarn 4 now makes the default protocol of `npm` (e.g. `"foo": "*"` is really `"foo": "npm:*"`) explicit in the lockfile representation. This means that workspaces that reference a package with and without a protocol will end up with multiple protocols for a single descriptor. e.g. If one package has a dependency `"c": "*"` and another package in the workspace has a dependency `"c": "workspace:*"` In Yarn3 those result in the following descriptors: `c@*, c@workspace:*, c@workspace:pkgs/c` In Yarn4 those result in the following descriptors: `c@npm:*, c@workspace:*, c@workspace:pkgs/c` We cannot get rid of the logic for case without a protocol as that would break our Yarn3 usage. ### Testing Instructions Added unit test that has a lockfile with mixed protocols. Existing unit tests verify the Yarn3 behavior is still supported. Closes TURBO-1856 Co-authored-by: Chris Olszewski <Chris Olszewski>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify canary release
Link to code that reproduces this issue
https://github.com/FrancoRATOVOSON/e-commerce/tree/create-ui
What package manager are you using / does the bug impact?
Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Linux
Which canary version will you have in your reproduction?
turbo@npm:1.11.0 (via npm:^1.11.0)
Describe the Bug
The wode work when I run a script in a specific package with
yarn workspace [package-name] [script]but give me this message if with a turbo command :And this is the content of the
.tomlfile :Expected Behavior
I expect the script to work as before, and the same way with a turbo command or yarn workspace.
To Reproduce
There's nothing specific, the repos is there.
Additional context
I undid the last commit, but if you try to reproduce it, make sure tubo is above 1.7.4 (it should be 1.11.0 tho).
The text was updated successfully, but these errors were encountered: