Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Summary Prototype #1707

Closed
wants to merge 15 commits into from
Closed

Run Summary Prototype #1707

wants to merge 15 commits into from

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Aug 17, 2022

No description provided.

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ❌ Failed (Inspect) Nov 9, 2022 at 0:27AM (UTC)
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 0:27AM (UTC)
examples-kitchensink-blog ❌ Failed (Inspect) Nov 9, 2022 at 0:27AM (UTC)
examples-native-web ❌ Failed (Inspect) Nov 9, 2022 at 0:27AM (UTC)
examples-svelte-web ❌ Failed (Inspect) Nov 9, 2022 at 0:27AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 9, 2022 at 0:27AM (UTC)

@gsoltis gsoltis changed the title Gsoltis/run summary Run Summary Prototype Aug 17, 2022
@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 17, 2022

Sample summary from building the basic example:

{
        "durationMs": 93,
        "endedAt": 1660694445476,
        "sessionId": "2DSZSSlaJxJXSALCU5gznnVU0R4",
        "startedAt": 1660694445383,
        "tasks": {
                "docs#build": {
                        "durationMs": 32,
                        "endedAt": 1660694445473,
                        "startedAt": 1660694445441,
                        "status": "replayed"
                },
                "eslint-config-custom#build": {
                        "durationMs": 0,
                        "endedAt": 1660694445441,
                        "startedAt": 1660694445441,
                        "status": "nonexistent"
                },
                "tsconfig#build": {
                        "durationMs": 0,
                        "endedAt": 1660694445441,
                        "startedAt": 1660694445441,
                        "status": "nonexistent"
                },
                "ui#build": {
                        "durationMs": 0,
                        "endedAt": 1660694445441,
                        "startedAt": 1660694445441,
                        "status": "nonexistent"
                },
                "web#build": {
                        "durationMs": 35,
                        "endedAt": 1660694445476,
                        "startedAt": 1660694445441,
                        "status": "replayed"
                }
        }
}

@gsoltis gsoltis changed the base branch from main to gsoltis/run_state_refactor August 18, 2022 18:08
@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 18, 2022

Updated sample artifact:

{
	"durationMs": 51,
	"endedAt": 1660845823941,
	"sessionId": "2DXWHjwCe2xL7RSLhnRuQVKxbLf",
	"startedAt": 1660845823890,
	"tasks": {
		"docs#build": {
			"cache": {
				"cacheRead": "hit",
				"outputGlobs": [
					"apps/docs/.turbo/turbo-build.log",
					"apps/docs/dist/**",
					"apps/docs/.next/**"
				],
				"taskHash": "41446271347b39dc",
				"timeSavedMs": 3211
			},
			"durationMs": 19,
			"endedAt": 1660845823941,
			"startedAt": 1660845823921,
			"status": "replayed"
		},
		"eslint-config-custom#build": {
			"cache": null,
			"durationMs": 0,
			"endedAt": 1660845823921,
			"startedAt": 1660845823921,
			"status": "nonexistent"
		},
		"tsconfig#build": {
			"cache": null,
			"durationMs": 0,
			"endedAt": 1660845823921,
			"startedAt": 1660845823921,
			"status": "nonexistent"
		},
		"ui#build": {
			"cache": null,
			"durationMs": 0,
			"endedAt": 1660845823921,
			"startedAt": 1660845823921,
			"status": "nonexistent"
		},
		"web#build": {
			"cache": {
				"cacheRead": "hit",
				"outputGlobs": [
					"apps/web/.turbo/turbo-build.log",
					"apps/web/dist/**",
					"apps/web/.next/**"
				],
				"taskHash": "6a7024e8742617e0",
				"timeSavedMs": 3203
			},
			"durationMs": 19,
			"endedAt": 1660845823941,
			"startedAt": 1660845823921,
			"status": "replayed"
		}
	}
}

@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 19, 2022

Added a turbo recent and text representation. Going to pause here for UX review, then work on some stronger typing for the summaries.

Lots of possibilities for additional turbo recent flags and subcommands (clean, find, etc.)
Screen Shot 2022-08-19 at 12 21 08 PM

@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 19, 2022

cc @jaredpalmer I'd like to get your opinion on UX and what other details you'd like to see here.

@gsoltis gsoltis reopened this Sep 14, 2022
@mehulkar mehulkar changed the base branch from gsoltis/run_state_refactor to main November 8, 2022 01:19
@mehulkar
Copy link
Contributor

mehulkar commented Mar 3, 2023

@gsoltis we still don't have everything in this PR into main, but it's probably ok to close / delete this branch now?

@gsoltis
Copy link
Contributor Author

gsoltis commented Mar 3, 2023

Yup, closing in favor of a real implementation.

@gsoltis gsoltis closed this Mar 3, 2023
@mehulkar mehulkar deleted the gsoltis/run_summary branch January 5, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants