make colored output the default

[samchouse]

This PR removes the --color flag that doesn't do anything and makes outputting colors from ran tasks the default. This PR makes it the default because that is what most people expect when switching to Turbo from NX or normal repos and loss of color shouldn't be the default.

Default:

--color flag:

--no-color flag:

With this PR:

[vercel]

@Xenfo is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

[mehulkar]

This is generally what we want the end user experience to be, but we want to do it a different way:

• We want to remove colors (and prefixes) from logs that are written to disk
• We want to display colors (and prefixes) when printing to terminal / replay

If we just always add --color, it will not only invalidate existing caches, it will pollute the caches with the colors that may not be printable everywhere (e.g. CI systems).

Note: I'm still sort of new to this project, so I'm not 100% sure I understand correctly. @gsoltis can probably say more and whether this config change can still be accepted and without impacting the longer term solution! (See also conversation in #1349)

[gsoltis]

This looks like a confusion of two color settings:

1. The color setting for turbo's output. For example, should turbo use color for task prefixes
2. The color setting for tasks being run

The documentation for this flag definitely does not make this distinction, and it's somewhat unclear that there even ought to be a distinction here.

@mehulkar is correct in saying that we do need the ability to strip colors from logs appropriately before we can start logging them. This is unfortunately related to a large change that needs to come to log storage: moving towards just storing the raw output from the task, without any prefixes or caching information.

To move this forward, perhaps we can tackle the log replay aspect first. What about using the existing flags to control whether colors are stripped from log replay? This should initially be a no-op, since no colors are stored there, but paves the way to being able to store them safely.

[samchouse]

Sure whatever you think is best, I'm willing to give it a go. I'm still a little confused though, are we trying to modify the flags to remove colors from the saved log files before we replay them?

[mehulkar]

@Xenfo you may be interested in #2126. It attempts--hopefully I got everything--to ensure that output from tasks that is stored on disk for caching does not include any output from turbo (i.e. no prefixes and no messages from turbo). It adds those in only during display to terminal.

I'd like to revisit this PR and what you're trying to solve after we release that (likely in 1.6)