Fix large regression with turning ModuleRuleCondition::matches into a tt::fun #2450

alexkirsz · 2022-10-28T05:59:23Z

Turning ModuleRuleCondition::matches into a tt::fun generates ~500,000 tasks just for the 10k modules app. Our overhead per-task is quite high at the moment, so it doesn't make sense to pay that cost. On 20k modules I see a ~6% performance improvement.

TODO: We don't need to turn ModuleRuleCondition into a Vc at all. It could store a FileSystemPathReadRef/RegexReadRef directly. I'll do that next.

… a tt::fun

vercel · 2022-10-28T05:59:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-basic-web	🔄 Building (Inspect)			Oct 28, 2022 at 6:47AM (UTC)

5 Ignored Deployments

Name	Status	Preview	Updated
examples-designsystem-docs	⬜️ Ignored (Inspect)		Oct 28, 2022 at 6:47AM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)		Oct 28, 2022 at 6:47AM (UTC)
examples-native-web	⬜️ Ignored (Inspect)		Oct 28, 2022 at 6:47AM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)		Oct 28, 2022 at 6:47AM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Oct 28, 2022 at 6:47AM (UTC)

jridgewell · 2022-10-28T06:11:25Z

crates/turbopack/src/module_options/module_rule.rs

            }
            _ => todo!("not implemented yet"),
        })
    }
+
+    pub fn matches_boxed(


I'm adding the async_recursion crate in #2426, because this pinboxdynfut hurts to think about.

I'm getting rid of all async in this module next, as we don't need to store Vcs. We can store ReadRefs instead.

jridgewell · 2022-10-28T06:14:35Z

crates/turbopack/src/module_options/module_rule.rs

 impl ModuleRuleVc {
-    #[turbo_tasks::function]


I wonder if this is 2x, because ModuleRuleConditionVc::matches was a task, and this is a task that only depends on that task (and self, but I don't think that counts).

Also, ModuleRuleConditionVc::matches was recursive.

jridgewell · 2022-10-28T06:15:15Z

crates/turbopack/src/module_options/module_rule.rs

 impl ModuleRuleConditionVc {
-    #[turbo_tasks::function]
-    pub async fn matches(self, path: FileSystemPathVc) -> Result<BoolVc> {
+    pub async fn matches(self, path: FileSystemPathVc) -> Result<bool> {


This actually seems expensive to recompute continually.

It will only get recomputed if the function that calls this gets recomputed. At the moment, this is cheaper than the turbo_tasks overhead.

We might want to turn the top-level ModuleRule::matches back into a turbo_tasks::function at some point, but for now this is faster.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`1.6.2` -> `1.6.3`](https://renovatebot.com/diffs/npm/turbo/1.6.2/1.6.3) | [![age](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/compatibility-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/confidence-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.6.3`](https://togithub.com/vercel/turbo/releases/tag/v1.6.3) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.6.2...v1.6.3) #### What's Changed - Merge release branch staging-1.6.2 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2453 - refactor(next/dev): allow devserver args serializable by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2446 - Fix large regression with turning ModuleRuleCondition::matches into a tt::fun by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2450 - chore: typo by [@ahaoboy](https://togithub.com/ahaoboy) in [vercel/turbo#2404 - refactor(next/dev): reusable start_server by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2455 - Breakdown /packages code ownership by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2459 - make sure to exit the process in case of errors during errors sending by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2457 - docs: change with-pnpm run command by [@pahaz](https://togithub.com/pahaz) in [vercel/turbo#2468 - Fix internal link in docs by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2465 - improve startup and warmup of benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2463 - improve performance of to_entry_snapshot by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2462 - fix prettier by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2471 - fix workflow links by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2472 - Avoid recomputing all_assets_map on every change by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2464 - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.1 by [@renovate](https://togithub.com/renovate) in [vercel/turbo#2244 - Use dashmap+fxhash instead of flurry by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2431 - remove require hook by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2473 - Faster source map tracing by [@jridgewell](https://togithub.com/jridgewell) in [vercel/turbo#2426 - Warn on not-yet-supported module usage by [@wbinnssmith](https://togithub.com/wbinnssmith) in [vercel/turbo#2422 - Use the same hashing logic for sourcemap names by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2475 - Avoid expensive background work by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2482 - Simplify benchmark warmup by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2483 - change source map handling to not invalidate on file change by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2474 - improve chunk optimization by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2476 - add TURBOPACK_BENCH_PROGRESS to show captured values during bench by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2490 - optimize chunks to be a smaller by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2491 - avoid to read_dir syscall for all files by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2495 - feat(next/dev): allow to retry bind by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2480 - ci(action): workaround windows node-gyp failure by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2504 - ci(action): bump up rust cache by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2505 - fix bad performance in ApplyVisitors by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2501 - Correct all domain and repository references. by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2508 - Fix rounding issue and use proper units by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2516 - fix: create-turbo update next version in templates by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#2519 - add documentation about benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2492 - benchmark graph nit by [@gaspar09](https://togithub.com/gaspar09) in [vercel/turbo#2524 - Disable pagination links in the footer on /blog by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2526 - Improve error message for missing task definitions by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2267 - Fix line-height of blog post articles by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2527 - Merge release branch staging-1.6.3-canary.0 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2531 #### New Contributors - [@evliu](https://togithub.com/evliu) made their first contribution in [vercel/turbo#2164 - [@blake-mealey](https://togithub.com/blake-mealey) made their first contribution in [vercel/turbo#2179 - [@erikhofer](https://togithub.com/erikhofer) made their first contribution in [vercel/turbo#2225 - [@adarshaacharya](https://togithub.com/adarshaacharya) made their first contribution in [vercel/turbo#2228 - [@MateoKruk](https://togithub.com/MateoKruk) made their first contribution in [vercel/turbo#2240 - [@rgomezcasas](https://togithub.com/rgomezcasas) made their first contribution in [vercel/turbo#2209 - [@benjervis](https://togithub.com/benjervis) made their first contribution in [vercel/turbo#2290 - [@junhoyeo](https://togithub.com/junhoyeo) made their first contribution in [vercel/turbo#2295 - [@sokra](https://togithub.com/sokra) made their first contribution in [vercel/turbo#2315 - [@ernestd](https://togithub.com/ernestd) made their first contribution in [vercel/turbo#2322 - [@vacekj](https://togithub.com/vacekj) made their first contribution in [vercel/turbo#2330 - [@Just-Moh-it](https://togithub.com/Just-Moh-it) made their first contribution in [vercel/turbo#2328 - [@pelleknaap](https://togithub.com/pelleknaap) made their first contribution in [vercel/turbo#2329 - [@simonw](https://togithub.com/simonw) made their first contribution in [vercel/turbo#2326 - [@jomlamladen](https://togithub.com/jomlamladen) made their first contribution in [vercel/turbo#2334 - [@harish-sethuraman](https://togithub.com/harish-sethuraman) made their first contribution in [vercel/turbo#2333 - [@debdutdeb](https://togithub.com/debdutdeb) made their first contribution in [vercel/turbo#2331 - [@sosukesuzuki](https://togithub.com/sosukesuzuki) made their first contribution in [vercel/turbo#2360 - [@chunsch](https://togithub.com/chunsch) made their first contribution in [vercel/turbo#2358 - [@zEh-](https://togithub.com/zEh-) made their first contribution in [vercel/turbo#2342 - [@KarnellSchultz](https://togithub.com/KarnellSchultz) made their first contribution in [vercel/turbo#2376 - [@lpalmes](https://togithub.com/lpalmes) made their first contribution in [vercel/turbo#2368 - [@hijuliancode](https://togithub.com/hijuliancode) made their first contribution in [vercel/turbo#2354 - [@ChFlick](https://togithub.com/ChFlick) made their first contribution in [vercel/turbo#2373 - [@thiagodebastos](https://togithub.com/thiagodebastos) made their first contribution in [vercel/turbo#2383 - [@wbinnssmith](https://togithub.com/wbinnssmith) made their first contribution in [vercel/turbo#2385 - [@alexkirsz](https://togithub.com/alexkirsz) made their first contribution in [vercel/turbo#2395 - [@Brooooooklyn](https://togithub.com/Brooooooklyn) made their first contribution in [vercel/turbo#2366 - [@peterpme](https://togithub.com/peterpme) made their first contribution in [vercel/turbo#2413 - [@johanholmerin](https://togithub.com/johanholmerin) made their first contribution in [vercel/turbo#2429 - [@ijjk](https://togithub.com/ijjk) made their first contribution in [vercel/turbo#2434 - [@bdbai](https://togithub.com/bdbai) made their first contribution in [vercel/turbo#2364 - [@allan2](https://togithub.com/allan2) made their first contribution in [vercel/turbo#2443 - [@ahaoboy](https://togithub.com/ahaoboy) made their first contribution in [vercel/turbo#2404 - [@pahaz](https://togithub.com/pahaz) made their first contribution in [vercel/turbo#2468 **Full Changelog**: vercel/turbo@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`^1.6.2` -> `^1.6.3`](https://renovatebot.com/diffs/npm/turbo/1.6.2/1.6.3) | [![age](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/compatibility-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/confidence-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.6.3`](https://togithub.com/vercel/turbo/releases/tag/v1.6.3) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.6.2...v1.6.3) #### What's Changed - Merge release branch staging-1.6.2 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2453 - refactor(next/dev): allow devserver args serializable by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2446 - Fix large regression with turning ModuleRuleCondition::matches into a tt::fun by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2450 - chore: typo by [@ahaoboy](https://togithub.com/ahaoboy) in [vercel/turbo#2404 - refactor(next/dev): reusable start_server by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2455 - Breakdown /packages code ownership by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2459 - make sure to exit the process in case of errors during errors sending by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2457 - docs: change with-pnpm run command by [@pahaz](https://togithub.com/pahaz) in [vercel/turbo#2468 - Fix internal link in docs by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2465 - improve startup and warmup of benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2463 - improve performance of to_entry_snapshot by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2462 - fix prettier by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2471 - fix workflow links by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2472 - Avoid recomputing all_assets_map on every change by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2464 - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.1 by [@renovate](https://togithub.com/renovate) in [vercel/turbo#2244 - Use dashmap+fxhash instead of flurry by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2431 - remove require hook by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2473 - Faster source map tracing by [@jridgewell](https://togithub.com/jridgewell) in [vercel/turbo#2426 - Warn on not-yet-supported module usage by [@wbinnssmith](https://togithub.com/wbinnssmith) in [vercel/turbo#2422 - Use the same hashing logic for sourcemap names by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2475 - Avoid expensive background work by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2482 - Simplify benchmark warmup by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2483 - change source map handling to not invalidate on file change by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2474 - improve chunk optimization by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2476 - add TURBOPACK_BENCH_PROGRESS to show captured values during bench by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2490 - optimize chunks to be a smaller by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2491 - avoid to read_dir syscall for all files by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2495 - feat(next/dev): allow to retry bind by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2480 - ci(action): workaround windows node-gyp failure by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2504 - ci(action): bump up rust cache by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2505 - fix bad performance in ApplyVisitors by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2501 - Correct all domain and repository references. by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2508 - Fix rounding issue and use proper units by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2516 - fix: create-turbo update next version in templates by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#2519 - add documentation about benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2492 - benchmark graph nit by [@gaspar09](https://togithub.com/gaspar09) in [vercel/turbo#2524 - Disable pagination links in the footer on /blog by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2526 - Improve error message for missing task definitions by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2267 - Fix line-height of blog post articles by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2527 - Merge release branch staging-1.6.3-canary.0 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2531 #### New Contributors - [@evliu](https://togithub.com/evliu) made their first contribution in [vercel/turbo#2164 - [@blake-mealey](https://togithub.com/blake-mealey) made their first contribution in [vercel/turbo#2179 - [@erikhofer](https://togithub.com/erikhofer) made their first contribution in [vercel/turbo#2225 - [@adarshaacharya](https://togithub.com/adarshaacharya) made their first contribution in [vercel/turbo#2228 - [@MateoKruk](https://togithub.com/MateoKruk) made their first contribution in [vercel/turbo#2240 - [@rgomezcasas](https://togithub.com/rgomezcasas) made their first contribution in [vercel/turbo#2209 - [@benjervis](https://togithub.com/benjervis) made their first contribution in [vercel/turbo#2290 - [@junhoyeo](https://togithub.com/junhoyeo) made their first contribution in [vercel/turbo#2295 - [@sokra](https://togithub.com/sokra) made their first contribution in [vercel/turbo#2315 - [@ernestd](https://togithub.com/ernestd) made their first contribution in [vercel/turbo#2322 - [@vacekj](https://togithub.com/vacekj) made their first contribution in [vercel/turbo#2330 - [@Just-Moh-it](https://togithub.com/Just-Moh-it) made their first contribution in [vercel/turbo#2328 - [@pelleknaap](https://togithub.com/pelleknaap) made their first contribution in [vercel/turbo#2329 - [@simonw](https://togithub.com/simonw) made their first contribution in [vercel/turbo#2326 - [@jomlamladen](https://togithub.com/jomlamladen) made their first contribution in [vercel/turbo#2334 - [@harish-sethuraman](https://togithub.com/harish-sethuraman) made their first contribution in [vercel/turbo#2333 - [@debdutdeb](https://togithub.com/debdutdeb) made their first contribution in [vercel/turbo#2331 - [@sosukesuzuki](https://togithub.com/sosukesuzuki) made their first contribution in [vercel/turbo#2360 - [@chunsch](https://togithub.com/chunsch) made their first contribution in [vercel/turbo#2358 - [@zEh-](https://togithub.com/zEh-) made their first contribution in [vercel/turbo#2342 - [@KarnellSchultz](https://togithub.com/KarnellSchultz) made their first contribution in [vercel/turbo#2376 - [@lpalmes](https://togithub.com/lpalmes) made their first contribution in [vercel/turbo#2368 - [@hijuliancode](https://togithub.com/hijuliancode) made their first contribution in [vercel/turbo#2354 - [@ChFlick](https://togithub.com/ChFlick) made their first contribution in [vercel/turbo#2373 - [@thiagodebastos](https://togithub.com/thiagodebastos) made their first contribution in [vercel/turbo#2383 - [@wbinnssmith](https://togithub.com/wbinnssmith) made their first contribution in [vercel/turbo#2385 - [@alexkirsz](https://togithub.com/alexkirsz) made their first contribution in [vercel/turbo#2395 - [@Brooooooklyn](https://togithub.com/Brooooooklyn) made their first contribution in [vercel/turbo#2366 - [@peterpme](https://togithub.com/peterpme) made their first contribution in [vercel/turbo#2413 - [@johanholmerin](https://togithub.com/johanholmerin) made their first contribution in [vercel/turbo#2429 - [@ijjk](https://togithub.com/ijjk) made their first contribution in [vercel/turbo#2434 - [@bdbai](https://togithub.com/bdbai) made their first contribution in [vercel/turbo#2364 - [@allan2](https://togithub.com/allan2) made their first contribution in [vercel/turbo#2443 - [@ahaoboy](https://togithub.com/ahaoboy) made their first contribution in [vercel/turbo#2404 - [@pahaz](https://togithub.com/pahaz) made their first contribution in [vercel/turbo#2468 **Full Changelog**: vercel/turbo@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`1.6.2` -> `1.6.3`](https://renovatebot.com/diffs/npm/turbo/1.6.2/1.6.3) | [![age](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/compatibility-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/confidence-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.6.3`](https://togithub.com/vercel/turbo/releases/tag/v1.6.3) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.6.2...v1.6.3) #### What's Changed - Merge release branch staging-1.6.2 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2453 - refactor(next/dev): allow devserver args serializable by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2446 - Fix large regression with turning ModuleRuleCondition::matches into a tt::fun by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2450 - chore: typo by [@ahaoboy](https://togithub.com/ahaoboy) in [vercel/turbo#2404 - refactor(next/dev): reusable start_server by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2455 - Breakdown /packages code ownership by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2459 - make sure to exit the process in case of errors during errors sending by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2457 - docs: change with-pnpm run command by [@pahaz](https://togithub.com/pahaz) in [vercel/turbo#2468 - Fix internal link in docs by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2465 - improve startup and warmup of benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2463 - improve performance of to_entry_snapshot by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2462 - fix prettier by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2471 - fix workflow links by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2472 - Avoid recomputing all_assets_map on every change by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2464 - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.1 by [@renovate](https://togithub.com/renovate) in [vercel/turbo#2244 - Use dashmap+fxhash instead of flurry by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2431 - remove require hook by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2473 - Faster source map tracing by [@jridgewell](https://togithub.com/jridgewell) in [vercel/turbo#2426 - Warn on not-yet-supported module usage by [@wbinnssmith](https://togithub.com/wbinnssmith) in [vercel/turbo#2422 - Use the same hashing logic for sourcemap names by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2475 - Avoid expensive background work by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2482 - Simplify benchmark warmup by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2483 - change source map handling to not invalidate on file change by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2474 - improve chunk optimization by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2476 - add TURBOPACK_BENCH_PROGRESS to show captured values during bench by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2490 - optimize chunks to be a smaller by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2491 - avoid to read_dir syscall for all files by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2495 - feat(next/dev): allow to retry bind by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2480 - ci(action): workaround windows node-gyp failure by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2504 - ci(action): bump up rust cache by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2505 - fix bad performance in ApplyVisitors by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2501 - Correct all domain and repository references. by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2508 - Fix rounding issue and use proper units by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2516 - fix: create-turbo update next version in templates by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#2519 - add documentation about benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2492 - benchmark graph nit by [@gaspar09](https://togithub.com/gaspar09) in [vercel/turbo#2524 - Disable pagination links in the footer on /blog by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2526 - Improve error message for missing task definitions by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2267 - Fix line-height of blog post articles by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2527 - Merge release branch staging-1.6.3-canary.0 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2531 #### New Contributors - [@evliu](https://togithub.com/evliu) made their first contribution in [vercel/turbo#2164 - [@blake-mealey](https://togithub.com/blake-mealey) made their first contribution in [vercel/turbo#2179 - [@erikhofer](https://togithub.com/erikhofer) made their first contribution in [vercel/turbo#2225 - [@adarshaacharya](https://togithub.com/adarshaacharya) made their first contribution in [vercel/turbo#2228 - [@MateoKruk](https://togithub.com/MateoKruk) made their first contribution in [vercel/turbo#2240 - [@rgomezcasas](https://togithub.com/rgomezcasas) made their first contribution in [vercel/turbo#2209 - [@benjervis](https://togithub.com/benjervis) made their first contribution in [vercel/turbo#2290 - [@junhoyeo](https://togithub.com/junhoyeo) made their first contribution in [vercel/turbo#2295 - [@sokra](https://togithub.com/sokra) made their first contribution in [vercel/turbo#2315 - [@ernestd](https://togithub.com/ernestd) made their first contribution in [vercel/turbo#2322 - [@vacekj](https://togithub.com/vacekj) made their first contribution in [vercel/turbo#2330 - [@Just-Moh-it](https://togithub.com/Just-Moh-it) made their first contribution in [vercel/turbo#2328 - [@pelleknaap](https://togithub.com/pelleknaap) made their first contribution in [vercel/turbo#2329 - [@simonw](https://togithub.com/simonw) made their first contribution in [vercel/turbo#2326 - [@jomlamladen](https://togithub.com/jomlamladen) made their first contribution in [vercel/turbo#2334 - [@harish-sethuraman](https://togithub.com/harish-sethuraman) made their first contribution in [vercel/turbo#2333 - [@debdutdeb](https://togithub.com/debdutdeb) made their first contribution in [vercel/turbo#2331 - [@sosukesuzuki](https://togithub.com/sosukesuzuki) made their first contribution in [vercel/turbo#2360 - [@chunsch](https://togithub.com/chunsch) made their first contribution in [vercel/turbo#2358 - [@zEh-](https://togithub.com/zEh-) made their first contribution in [vercel/turbo#2342 - [@KarnellSchultz](https://togithub.com/KarnellSchultz) made their first contribution in [vercel/turbo#2376 - [@lpalmes](https://togithub.com/lpalmes) made their first contribution in [vercel/turbo#2368 - [@hijuliancode](https://togithub.com/hijuliancode) made their first contribution in [vercel/turbo#2354 - [@ChFlick](https://togithub.com/ChFlick) made their first contribution in [vercel/turbo#2373 - [@thiagodebastos](https://togithub.com/thiagodebastos) made their first contribution in [vercel/turbo#2383 - [@wbinnssmith](https://togithub.com/wbinnssmith) made their first contribution in [vercel/turbo#2385 - [@alexkirsz](https://togithub.com/alexkirsz) made their first contribution in [vercel/turbo#2395 - [@Brooooooklyn](https://togithub.com/Brooooooklyn) made their first contribution in [vercel/turbo#2366 - [@peterpme](https://togithub.com/peterpme) made their first contribution in [vercel/turbo#2413 - [@johanholmerin](https://togithub.com/johanholmerin) made their first contribution in [vercel/turbo#2429 - [@ijjk](https://togithub.com/ijjk) made their first contribution in [vercel/turbo#2434 - [@bdbai](https://togithub.com/bdbai) made their first contribution in [vercel/turbo#2364 - [@allan2](https://togithub.com/allan2) made their first contribution in [vercel/turbo#2443 - [@ahaoboy](https://togithub.com/ahaoboy) made their first contribution in [vercel/turbo#2404 - [@pahaz](https://togithub.com/pahaz) made their first contribution in [vercel/turbo#2468 **Full Changelog**: vercel/turbo@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`^1.6.2` -> `^1.6.3`](https://renovatebot.com/diffs/npm/turbo/1.6.2/1.6.3) | [![age](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/compatibility-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/turbo/1.6.3/confidence-slim/1.6.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turbo</summary> ### [`v1.6.3`](https://togithub.com/vercel/turbo/releases/tag/v1.6.3) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.6.2...v1.6.3) #### What's Changed - Merge release branch staging-1.6.2 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2453 - refactor(next/dev): allow devserver args serializable by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2446 - Fix large regression with turning ModuleRuleCondition::matches into a tt::fun by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2450 - chore: typo by [@ahaoboy](https://togithub.com/ahaoboy) in [vercel/turbo#2404 - refactor(next/dev): reusable start_server by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2455 - Breakdown /packages code ownership by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2459 - make sure to exit the process in case of errors during errors sending by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2457 - docs: change with-pnpm run command by [@pahaz](https://togithub.com/pahaz) in [vercel/turbo#2468 - Fix internal link in docs by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2465 - improve startup and warmup of benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2463 - improve performance of to_entry_snapshot by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2462 - fix prettier by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2471 - fix workflow links by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2472 - Avoid recomputing all_assets_map on every change by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2464 - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.1 by [@renovate](https://togithub.com/renovate) in [vercel/turbo#2244 - Use dashmap+fxhash instead of flurry by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2431 - remove require hook by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2473 - Faster source map tracing by [@jridgewell](https://togithub.com/jridgewell) in [vercel/turbo#2426 - Warn on not-yet-supported module usage by [@wbinnssmith](https://togithub.com/wbinnssmith) in [vercel/turbo#2422 - Use the same hashing logic for sourcemap names by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2475 - Avoid expensive background work by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2482 - Simplify benchmark warmup by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2483 - change source map handling to not invalidate on file change by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2474 - improve chunk optimization by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2476 - add TURBOPACK_BENCH_PROGRESS to show captured values during bench by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2490 - optimize chunks to be a smaller by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2491 - avoid to read_dir syscall for all files by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2495 - feat(next/dev): allow to retry bind by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2480 - ci(action): workaround windows node-gyp failure by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2504 - ci(action): bump up rust cache by [@kwonoj](https://togithub.com/kwonoj) in [vercel/turbo#2505 - fix bad performance in ApplyVisitors by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2501 - Correct all domain and repository references. by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2508 - Fix rounding issue and use proper units by [@alexkirsz](https://togithub.com/alexkirsz) in [vercel/turbo#2516 - fix: create-turbo update next version in templates by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#2519 - add documentation about benchmarks by [@sokra](https://togithub.com/sokra) in [vercel/turbo#2492 - benchmark graph nit by [@gaspar09](https://togithub.com/gaspar09) in [vercel/turbo#2524 - Disable pagination links in the footer on /blog by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2526 - Improve error message for missing task definitions by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#2267 - Fix line-height of blog post articles by [@shuding](https://togithub.com/shuding) in [vercel/turbo#2527 - Merge release branch staging-1.6.3-canary.0 by [@nathanhammond](https://togithub.com/nathanhammond) in [vercel/turbo#2531 #### New Contributors - [@evliu](https://togithub.com/evliu) made their first contribution in [vercel/turbo#2164 - [@blake-mealey](https://togithub.com/blake-mealey) made their first contribution in [vercel/turbo#2179 - [@erikhofer](https://togithub.com/erikhofer) made their first contribution in [vercel/turbo#2225 - [@adarshaacharya](https://togithub.com/adarshaacharya) made their first contribution in [vercel/turbo#2228 - [@MateoKruk](https://togithub.com/MateoKruk) made their first contribution in [vercel/turbo#2240 - [@rgomezcasas](https://togithub.com/rgomezcasas) made their first contribution in [vercel/turbo#2209 - [@benjervis](https://togithub.com/benjervis) made their first contribution in [vercel/turbo#2290 - [@junhoyeo](https://togithub.com/junhoyeo) made their first contribution in [vercel/turbo#2295 - [@sokra](https://togithub.com/sokra) made their first contribution in [vercel/turbo#2315 - [@ernestd](https://togithub.com/ernestd) made their first contribution in [vercel/turbo#2322 - [@vacekj](https://togithub.com/vacekj) made their first contribution in [vercel/turbo#2330 - [@Just-Moh-it](https://togithub.com/Just-Moh-it) made their first contribution in [vercel/turbo#2328 - [@pelleknaap](https://togithub.com/pelleknaap) made their first contribution in [vercel/turbo#2329 - [@simonw](https://togithub.com/simonw) made their first contribution in [vercel/turbo#2326 - [@jomlamladen](https://togithub.com/jomlamladen) made their first contribution in [vercel/turbo#2334 - [@harish-sethuraman](https://togithub.com/harish-sethuraman) made their first contribution in [vercel/turbo#2333 - [@debdutdeb](https://togithub.com/debdutdeb) made their first contribution in [vercel/turbo#2331 - [@sosukesuzuki](https://togithub.com/sosukesuzuki) made their first contribution in [vercel/turbo#2360 - [@chunsch](https://togithub.com/chunsch) made their first contribution in [vercel/turbo#2358 - [@zEh-](https://togithub.com/zEh-) made their first contribution in [vercel/turbo#2342 - [@KarnellSchultz](https://togithub.com/KarnellSchultz) made their first contribution in [vercel/turbo#2376 - [@lpalmes](https://togithub.com/lpalmes) made their first contribution in [vercel/turbo#2368 - [@hijuliancode](https://togithub.com/hijuliancode) made their first contribution in [vercel/turbo#2354 - [@ChFlick](https://togithub.com/ChFlick) made their first contribution in [vercel/turbo#2373 - [@thiagodebastos](https://togithub.com/thiagodebastos) made their first contribution in [vercel/turbo#2383 - [@wbinnssmith](https://togithub.com/wbinnssmith) made their first contribution in [vercel/turbo#2385 - [@alexkirsz](https://togithub.com/alexkirsz) made their first contribution in [vercel/turbo#2395 - [@Brooooooklyn](https://togithub.com/Brooooooklyn) made their first contribution in [vercel/turbo#2366 - [@peterpme](https://togithub.com/peterpme) made their first contribution in [vercel/turbo#2413 - [@johanholmerin](https://togithub.com/johanholmerin) made their first contribution in [vercel/turbo#2429 - [@ijjk](https://togithub.com/ijjk) made their first contribution in [vercel/turbo#2434 - [@bdbai](https://togithub.com/bdbai) made their first contribution in [vercel/turbo#2364 - [@allan2](https://togithub.com/allan2) made their first contribution in [vercel/turbo#2443 - [@ahaoboy](https://togithub.com/ahaoboy) made their first contribution in [vercel/turbo#2404 - [@pahaz](https://togithub.com/pahaz) made their first contribution in [vercel/turbo#2468 **Full Changelog**: vercel/turbo@v1.6.2...v1.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

… tt::fun (vercel/turbo#2450) * Fix large regression with turning ModuleRuleConditionVc::matches into a tt::fun * Remove Vcs from ModuleRule altogether

Fix large regression with turning ModuleRuleConditionVc::matches into…

9bd1344

… a tt::fun

alexkirsz requested a review from a team as a code owner October 28, 2022 05:59

jridgewell reviewed Oct 28, 2022

View reviewed changes

Remove Vcs from ModuleRule altogether

f2fa40d

alexkirsz requested a review from jridgewell October 28, 2022 06:49

sokra approved these changes Oct 28, 2022

View reviewed changes

sokra merged commit 4c1463a into main Oct 28, 2022

sokra deleted the alexkirsz/fix-matches-regression branch October 28, 2022 15:53

jridgewell added the area: turbopack label Oct 28, 2022

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix large regression with turning ModuleRuleCondition::matches into a tt::fun #2450

Fix large regression with turning ModuleRuleCondition::matches into a tt::fun #2450

alexkirsz commented Oct 28, 2022

vercel bot commented Oct 28, 2022 •

edited

Loading

jridgewell Oct 28, 2022

alexkirsz Oct 28, 2022

jridgewell Oct 28, 2022

alexkirsz Oct 28, 2022

jridgewell Oct 28, 2022

alexkirsz Oct 28, 2022

Fix large regression with turning ModuleRuleCondition::matches into a tt::fun #2450

Fix large regression with turning ModuleRuleCondition::matches into a tt::fun #2450

Conversation

alexkirsz commented Oct 28, 2022

vercel bot commented Oct 28, 2022 • edited Loading

jridgewell Oct 28, 2022

Choose a reason for hiding this comment

alexkirsz Oct 28, 2022

Choose a reason for hiding this comment

jridgewell Oct 28, 2022

Choose a reason for hiding this comment

alexkirsz Oct 28, 2022

Choose a reason for hiding this comment

jridgewell Oct 28, 2022

Choose a reason for hiding this comment

alexkirsz Oct 28, 2022

Choose a reason for hiding this comment

vercel bot commented Oct 28, 2022 •

edited

Loading