Page data HMR #3132
Merged
Page data HMR #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 10 Ignored Deployments
|
| */ | ||
| function subscribePageData({ assetPrefix }: { assetPrefix: string }) { | ||
| const pageChunkPath = location.pathname.slice(1); | ||
| const dataPath = `_next/data/development/${pageChunkPath}.json`; |
There was a problem hiding this comment.
I think we also need to update this on client side navigation
There was a problem hiding this comment.
Good catch. I've updated it so it unsubscribes and resubscribes when navigating to a different page.
alexkirsz
force-pushed
the
alexkirsz/web-218-hmr-for-data-in-pages-getserversideprops
branch
from
333d500
to
b80c5c2
Compare
|
alexkirsz
force-pushed
the
alexkirsz/web-218-hmr-for-data-in-pages-getserversideprops
branch
from
b80c5c2
to
a272d49
Compare
Benchmark for 23cd37aClick to view benchmark
|
alexkirsz
force-pushed
the
alexkirsz/web-218-hmr-for-data-in-pages-getserversideprops
branch
from
628f0a5
to
680803d
Compare
ForsakenHarmony
approved these changes
Jan 3, 2023
| @@ -249,8 +261,11 @@ function handleSocketMessage(msg: ServerMessage) { | |||
| } | |||
| } | |||
|
|
|||
| export function onChunkUpdate(chunkPath: ChunkPath, callback: UpdateCallback) { | |||
| onUpdate( | |||
| export function onChunkUpdate( | |||
There was a problem hiding this comment.
Maybe we should have consistent naming here, other functions above and below start with subscribeTo, this one with on
Benchmark for e8f5344Click to view benchmark
|
alexkirsz
added
the
pr: automerge
Benchmark for a69f100Click to view benchmark
|
alexkirsz
deleted the
alexkirsz/web-218-hmr-for-data-in-pages-getserversideprops
branch
This was referenced Jan 20, 2023
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Based on vercel/turbo#2968 This builds upon vercel/turbo#2968 and @ForsakenHarmony's work on data routes to enable page data HMR. Page data HMR is a bit more clever than it is in Next.js as we won't re-render a Node.js result for each page file update. Instead, thanks to the `StripPageDefaultExport` transform, there are three versions of the page chunks: * client-side (strips page data exports); * server-side (full); * data server-side (strips page default export). Instead of subscribing to the full server-side result, on hydration, the client-side page separately subscribes to: * client-side updates (already the case); * data server-side updates (new). This means that updating something that only affects the page component will only cause a client-side update and **no Node.js re-rendering**, while updating something that only affects the data will only cause a server-side update. ~~I'm marking this as a draft for now as there are still a few areas to test/investigate:~~ - [x] When something that is used in both the default page export and data exports is changed, this will cause *two* HMR updates: one data update, and one client-side chunk update. **The same case breaks in Next.js, where we will receive a client-side update, but no server-side update, ending up with an incorrect result.** - [x] Differences between `getStaticProps/getServerSideProps`, as well as `getInitialProps` (need to talk with @timneutkens about this) (see #44523) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Based on vercel/turbo#2968 This builds upon vercel/turbo#2968 and @ForsakenHarmony's work on data routes to enable page data HMR. Page data HMR is a bit more clever than it is in Next.js as we won't re-render a Node.js result for each page file update. Instead, thanks to the `StripPageDefaultExport` transform, there are three versions of the page chunks: * client-side (strips page data exports); * server-side (full); * data server-side (strips page default export). Instead of subscribing to the full server-side result, on hydration, the client-side page separately subscribes to: * client-side updates (already the case); * data server-side updates (new). This means that updating something that only affects the page component will only cause a client-side update and **no Node.js re-rendering**, while updating something that only affects the data will only cause a server-side update. ~~I'm marking this as a draft for now as there are still a few areas to test/investigate:~~ - [x] When something that is used in both the default page export and data exports is changed, this will cause *two* HMR updates: one data update, and one client-side chunk update. **The same case breaks in Next.js, where we will receive a client-side update, but no server-side update, ending up with an incorrect result.** - [x] Differences between `getStaticProps/getServerSideProps`, as well as `getInitialProps` (need to talk with @timneutkens about this) (see #44523) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2968
This builds upon #2968 and @ForsakenHarmony's work on data routes to enable page data HMR.
Page data HMR is a bit more clever than it is in Next.js as we won't re-render a Node.js result for each page file update. Instead, thanks to the
StripPageDefaultExporttransform, there are three versions of the page chunks:Instead of subscribing to the full server-side result, on hydration, the client-side page separately subscribes to:
This means that updating something that only affects the page component will only cause a client-side update and no Node.js re-rendering, while updating something that only affects the data will only cause a server-side update.
I'm marking this as a draft for now as there are still a few areas to test/investigate:getStaticProps/getServerSideProps, as well asgetInitialProps(need to talk with @timneutkens about this) (see Exclude development from static html/json render on data request next.js#44523)