Correctly hash empty outputs first #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/BzLwzjRmC9Y6DN2rq79uTw91JEfJ |
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Many small things I found The most important is probably the typescript transform The remaining bits should hopefully be self-explanatory from the commit messages
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Had added this to run nextest in #341, but because it doesn't work I had reverted part of the change, just not this
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
Many small things I found The most important is probably the typescript transform The remaining bits should hopefully be self-explanatory from the commit messages
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
Many small things I found The most important is probably the typescript transform The remaining bits should hopefully be self-explanatory from the commit messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue where if you ran a task without outputs defined, it gets cached, and then you changed outputs to be empty. You would get an incorrect cache hit because the of when in the codebase we hashed outputs (prior to setting defaults). This PR fixes that issue.