fix: preserve file permission

[rubiagatra]

Close #156

This is only draft if someone can have discussion with me it would be great

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/FBiFEm5tcwgBgrfirxfTVP1Gn2aQ
✅ Preview: https://turbo-site-git-fork-rubiagatra-fix-preserved-file-permission.vercel.sh

[jaredpalmer]

Can you change the call sites to pass 0 to preserve permissions?

turborepo/cli/internal/cache/cache_fs.go

Line 32 in 11665a9

err := fs.RecursiveCopyOrLinkFile(cachedFolder, target, fs.DirPermissions, true, true)

turborepo/cli/internal/cache/cache_fs.go

Line 54 in 11665a9

if err := fs.CopyOrLinkFile(file, filepath.Join(f.cacheDirectory, hash, rel), fs.DirPermissions, fs.DirPermissions, true, true); err != nil {

and in all of this file

https://github.com/vercel/turborepo/blob/a229aaa1c4aaecaef054adf09a8800ca74e4c1c6/cli/internal/prune/prune.go#L175-L291

and lastly here:

turborepo/cli/internal/run/run_state.go

Line 289 in 2ee2c40

if err := fs.CopyFile(chrometracing.Path(), name, fs.DirPermissions); err != nil {

[rubiagatra]

I just did that you requested @jaredpalmer and undo my draft commit.

1. Pass 0 instead of fs.DirPermissions
2. Run go test ./...

?   	turbo/cmd/turbo	[no test files]
?   	turbo/internal/api	[no test files]
?   	turbo/internal/backends	[no test files]
?   	turbo/internal/backends/nodejs	[no test files]
?   	turbo/internal/cache	[no test files]
?   	turbo/internal/client	[no test files]
?   	turbo/internal/config	[no test files]
ok  	turbo/internal/context	1.608s
ok  	turbo/internal/core	0.533s
ok  	turbo/internal/fs	1.295s
?   	turbo/internal/globby	[no test files]
?   	turbo/internal/info	[no test files]
?   	turbo/internal/login	[no test files]
ok  	turbo/internal/logstreamer	0.841s
?   	turbo/internal/prune	[no test files]
ok  	turbo/internal/run	2.290s
?   	turbo/internal/scm	[no test files]
?   	turbo/internal/ui	[no test files]
ok  	turbo/internal/ui/term	1.980s
ok  	turbo/internal/util	1.140s
?   	turbo/internal/util/browser	[no test files]
?   	turbo/internal/xxhash	[no test files]

Is there anything I can help with my changes to not break something?. I see potential test/documentation/onboarding improvement in the future, I am happy to help.

[jaredpalmer]

This unfortunately is more involved change. The current implementation breaks binary executables