add ==, !=, ===, !== operator support for evaluation #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
Benchmark for 91e6303
Click to view full benchmark
|
sokra
force-pushed
the
sokra/compile-time-value-refactor2
branch
from
8f74f7b
to
7628911
Compare
Benchmark for 92e58e5
Click to view full benchmark
|
sokra
force-pushed
the
sokra/compile-time-value-refactor2
branch
from
7628911
to
1402d03
Compare
Benchmark for efa717d
Click to view full benchmark
|
sokra
force-pushed
the
sokra/compile-time-value-refactor2
branch
from
1402d03
to
4f869f5
Compare
Benchmark for 5de35ee
Click to view full benchmark
|
sokra
force-pushed
the
sokra/compile-time-value-refactor2
branch
from
4f869f5
to
db66e9b
Compare
Benchmark for 4854a0f
Click to view full benchmark
|
alexkirsz
suggested changes
Feb 21, 2023
sokra
force-pushed
the
sokra/compile-time-value-refactor2
branch
from
db66e9b
to
f8f900a
Compare
Benchmark for b5b4438
Click to view full benchmark
|
|
performance will be fixed by follow-up PR: #3670 |
alexkirsz
approved these changes
Feb 22, 2023
sokra
added
the
pr: automerge
Benchmark for 88ba4ee
Click to view full benchmark
|
jridgewell
reviewed
Feb 22, 2023
Comment on lines
+1514
to
+1523
| ( | ||
| PositiveBinaryOperator::StrictEqual, | ||
| JsValue::Constant(a), | ||
| JsValue::Constant(b), | ||
| ) if a.is_value_type() => Some(a == b), | ||
| ( | ||
| PositiveBinaryOperator::StrictEqual, | ||
| JsValue::Constant(a), | ||
| JsValue::Constant(b), | ||
| ) if a.is_value_type() => { |
There was a problem hiding this comment.
Can this second branch ever execute? It's the same match as the first.
There was a problem hiding this comment.
yeah, the second branch can be removed. The first branch is an less verbose version of the first one
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #3670
depends on #3685
adds the equal operators to the evaluator