Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): give appropriate attribution to Microsoft Lage #370

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

jeffbcross
Copy link
Contributor

This pull request adds a note to the docs pages for “Scoped Tasks” and “Pipelines” to properly attribute Microsoft for copyrighted content that Turborepo copied from the documentation for Microsoft’s monorepo tool, Lage. Currently, both pages on Turborepo’s documentation come across as original work by the Turborepo team, even though the credit seems it mostly belongs with the Lage maintainers at Microsoft.

If you compare the pages on Turborepo’s and Lage’s docs, you can see how similar the text content, and APIs are:

The headings on both sites are nearly identical, and most of the text content is the same. As you can see by looking at the source for Lage’s Scoped Tasks page, the last edit was made on July 24, 2020, long before Turborepo was ever created. https://github.com/microsoft/lage/blob/master/docs/guide/scopes.md.
As you can see by looking at the source for Lage’s Pipelines page, the last edit was made on August 16, 2020, long before Turborepo was ever created. https://github.com/microsoft/lage/blob/master/docs/guide/pipeline.md.

@jaredpalmer acknowledged the Pipeline design came from Lage on Twitter back in March, but hasn’t given proper attribution for the docs pages that were copied from Lage. https://twitter.com/jaredpalmer/status/1377617245510250496?s=20

2021-03-31-kenneth_chau_jaredpalmer

The Lage repository is MIT licensed, which can be found here: https://github.com/microsoft/lage/blob/master/LICENSE. Note the following excerpt from the MIT license:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

For convenience, I’ve attached the text diff of the markdown files for both Turborepo and Lage, as well as screenshots of the pages on both sites.
Here is the Copyleaks report for the Pipelines page: https://copyleaks.com/education/report/dj88n4iptch6myn2/preview?key=ulrhw01ot1sqkiyk&viewMode=one-to-many&contentMode=html&sourcePage=1&suspectPage=1
Here is the Copyleaks report for the Scoped Tasks page: https://copyleaks.com/education/report/edkgued679mhw2kq/preview?key=v0bfr6qjy8qim9jg&viewMode=one-to-many&contentMode=html&sourcePage=1&suspectPage=1

If Turborepo has an agreement with Microsoft to use their intellectual property without attribution, please disregard this pull request.

pipeline-lage
pipeline-turborepo
scopes-lage
scopes-turborepo
pipeline-diff html
scoped-builds-diff html

The Scoped Tasks and Pipelines pages are copied from Microsoft’s
Monorepo tool, Lage. https://github.com/microsoft/lage

This gives proper attribution at the top of each of the docs
pages.
@vercel
Copy link

vercel bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/AQGyFufrzmiqmFt3LNDhdRMmZhNF
✅ Preview: https://turbo-site-git-fork-jeffbcross-add-attribution.vercel.sh

@jaredpalmer
Copy link
Contributor

Great idea! I actually Twitter DM'd with @kenotron (Lage author) a bunch while building Turbo to share ideas. Will keep this message until we land #105 which deprecates this syntax with something similar to PNPMs --filter flag.

@jaredpalmer jaredpalmer merged commit a8c593a into vercel:main Dec 20, 2021
@jeffbcross
Copy link
Contributor Author

Awesome!

@kenotron
Copy link

Yes, I believe turbo did end up using lage as a roadmap and maybe forking / starting point by looking at the similarity of structures in code. @jaredpalmer and I had indeed Twitter DM some, but we didn’t collab on code directly.

I do wish that we could have collaborated more rather than a complete rewrite - lage was fully functional for the scale to build most of the Office apps (including the new Loop stuff). I’m happy to see someone taking these ideas and implementing in native languages, but I’m not convinced that we are really bottlenecked by the orchestrator yet at our scale.

Anyway, attributions is great! I personally think there is room to have competing implementations. In fact, there are some other cool monorepo projects from Microsoft like rush and buildxl that might be of interest to whoever wants to dig!

@vercel vercel locked and limited conversation to collaborators Dec 21, 2021
@jaredpalmer
Copy link
Contributor

jaredpalmer commented Dec 21, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants