examples: Inject react runtime for ui package #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/DiTtxhRZdUoaVtajvxQ2W34exFq2 |
jaredpalmer
requested changes
Dec 20, 2021
jaredpalmer
reviewed
Dec 20, 2021
|
@jaredpalmer good call, updated with your suggestions! Thanks! |
jaredpalmer
approved these changes
Dec 23, 2021
jaredpalmer
changed the title
nareshbhatia
added a commit
to nareshbhatia/custom-react-stack
that referenced
this pull request
Apr 9, 2022
Without this tsup builds do not work with apps (see vercel/turborepo#371)
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
This allows us to reference the source maps for individual chunk items when delivering them for HMR updates. We currently send down the update via a `JSON.stringify()` of the updated module's code. We then `eval` this code to generate the new "module", and call registered hot handlers with the new module to update their scopes. Thankfully, we can include a `sourceMappingUrl` comment in the evaled code, so we can get away with deferring creating the source map's content until dev tools is opened. This is a first pass, it really needs to be cleaned up. But at least it's working. Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been changed?
buildanddevcommand forkitchen-sinkexamples ui package to support components that don't explicitly importReact.Why?
Starting from React 17, React shipped with the new JSX Transform, allowing components to include JSX without React being in scope (For example, the
Buttoncomponent included below). Because of this, it is now very common to write react components without explicitly importing React at all.However, in the current
kitchen-sinkexample, doing this will break, and throw:ReferenceError: React is not defined.How?
In order to support this common use case, we need to instruct
tsupto inject thereactruntime into the build. Becausetsupusesesbuild, we can leverage --inject to automatically replace a global variable with an import from another file. tsup has supported this argument (although poorly documented) since 5.3.0 (commit)Other
Fixing this will hopefully avoid frustration from new users who want to use an example as a starting point, with minimal changes to the build configuration.