loaders: use pre-compiled loader-runner distributed with Next.js #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benefit of this depends on vercel/next.js#45962, but it remains compatible with apps including `loader-runner`. This first attempts to require `loader-runner` from the app's installed version of Next.js, falling back to requiring the package directly. We should probably eventually remove this fallback once all compatible versions of Next.js include the precompiled version, as that has a more predictable version of the package. Test Plan: Linked a local copy of Next.js including vercel/next.js#45962 to an app without `loader-runner` that uses loaders and verified loaders ran.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Feb 15, 2023
Depends on #45962 and vercel/turbo#3823. This adds an example app that uses webpack loaders with Turbopack. It configures and uses the `@svgr/webpack` loader to transform svg assets into JavaScript as React components. Test Plan: `pnpm next-with-deps --turbo ./examples/with-turbopack-loaders`
Benchmark for 5868925Click to view benchmark
|
sokra
requested changes
Feb 16, 2023
Benchmark for 8bf2bb9Click to view benchmark
|
sokra
reviewed
Feb 21, 2023
|
|
||
| #[turbo_tasks::function] | ||
| pub async fn get_external_next_compiled_package_mapping( | ||
| package_name: StringVc, |
There was a problem hiding this comment.
Suggested change
| package_name: StringVc, | |
| package_name: &str, |
sokra
approved these changes
Feb 21, 2023
| try { | ||
| ({ runLoaders } = require("@vercel/turbopack/loader-runner")); | ||
| } catch { | ||
| ({ runLoaders } = __turbopack_external_require__("loader-runner")); |
wbinnssmith
added a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
Performance Improvements: * vercel/turbo#3849 Misc: * vercel/turbo#3850 * vercel/turbo#3861 * vercel/turbo#3823
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
# Performance Improvements: * vercel/turbo#3849 * vercel/turbo#3878 * vercel/turbo#3864 # Misc: * vercel/turbo#3847 * vercel/turbo#3865 * vercel/turbo#3850 * vercel/turbo#3861 * vercel/turbo#3823 * vercel/turbo#3882 # Contributing * Update profiling instructions for macOS ([#3837](vercel/turbo#3837))
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…cel/turbo#3823) The benefit of this depends on #45962, but it remains compatible with apps including `loader-runner`. This first attempts to require `loader-runner` from the app's installed version of Next.js, falling back to requiring the package directly. We should probably eventually remove this fallback once all compatible versions of Next.js include the precompiled version, as that has a more predictable version of the package. Test Plan: Linked a local copy of Next.js including #45962 to an app without `loader-runner` that uses loaders and verified loaders ran.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…cel/turbo#3823) The benefit of this depends on #45962, but it remains compatible with apps including `loader-runner`. This first attempts to require `loader-runner` from the app's installed version of Next.js, falling back to requiring the package directly. We should probably eventually remove this fallback once all compatible versions of Next.js include the precompiled version, as that has a more predictable version of the package. Test Plan: Linked a local copy of Next.js including #45962 to an app without `loader-runner` that uses loaders and verified loaders ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefit of this depends on vercel/next.js#45962, but it remains compatible with apps including
loader-runner.This first attempts to require
loader-runnerfrom the app's installed version of Next.js, falling back to requiring the package directly. We should probably eventually remove this fallback once all compatible versions of Next.js include the precompiled version, as that has a more predictable version of the package.Test Plan: Linked a local copy of Next.js including vercel/next.js#45962 to an app without
loader-runnerthat uses loaders and verified loaders ran.