improve performance of TaskScopes and collectibes #3849

sokra · 2023-02-17T00:10:37Z

No description provided.

vercel · 2023-02-17T00:10:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-cra-web	🔄 Building (Inspect)			Feb 17, 2023 at 3:11PM (UTC)
examples-kitchensink-blog	🔄 Building (Inspect)			Feb 17, 2023 at 3:11PM (UTC)
examples-svelte-web	🔄 Building (Inspect)			Feb 17, 2023 at 3:11PM (UTC)
examples-vite-web	🔄 Building (Inspect)			Feb 17, 2023 at 3:11PM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 17, 2023 at 3:11PM (UTC)

5 Ignored Deployments

Name	Status	Updated
examples-basic-web	⬜️ Ignored (Inspect)	Feb 17, 2023 at 3:11PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)	Feb 17, 2023 at 3:11PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)	Feb 17, 2023 at 3:11PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Feb 17, 2023 at 3:11PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Feb 17, 2023 at 3:11PM (UTC)

github-actions · 2023-02-17T00:28:02Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-02-17T01:23:15Z

Benchmark for `109df2c`

Test	Base	PR	%	Significant %
bench_hydration/Turbopack SSR/1000 modules	3622.14ms ± 21.50ms	3503.77ms ± 11.17ms	-3.27%	-1.48%
bench_startup/Turbopack CSR/1000 modules	2792.59ms ± 11.52ms	2724.55ms ± 15.03ms	-2.44%	-0.54%
bench_startup/Turbopack RCC/1000 modules	2323.45ms ± 5.28ms	2355.37ms ± 7.80ms	+1.37%	+0.25%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.29ms ± 0.09ms	10.26ms ± 0.14ms	-0.22%
bench_hmr_to_commit/Turbopack RCC/1000 modules	12.05ms ± 0.17ms	12.16ms ± 0.10ms	+0.91%
bench_hmr_to_commit/Turbopack RSC/1000 modules	520.81ms ± 1.69ms	516.33ms ± 1.18ms	-0.86%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.36ms ± 0.08ms	10.36ms ± 0.11ms	+0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9208.74µs ± 72.26µs	9265.69µs ± 92.94µs	+0.62%
bench_hmr_to_eval/Turbopack RCC/1000 modules	10.91ms ± 0.13ms	10.94ms ± 0.10ms	+0.27%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9241.26µs ± 95.22µs	9241.67µs ± 110.61µs	+0.00%
bench_hydration/Turbopack RCC/1000 modules	3929.27ms ± 38.87ms	3807.63ms ± 23.13ms	-3.10%
bench_hydration/Turbopack RSC/1000 modules	3480.12ms ± 7.63ms	3471.20ms ± 12.21ms	-0.26%
bench_hydration/Turbopack SSR/1000 modules	3622.14ms ± 21.50ms	3503.77ms ± 11.17ms	-3.27%	-1.48%
bench_startup/Turbopack CSR/1000 modules	2792.59ms ± 11.52ms	2724.55ms ± 15.03ms	-2.44%	-0.54%
bench_startup/Turbopack RCC/1000 modules	2323.45ms ± 5.28ms	2355.37ms ± 7.80ms	+1.37%	+0.25%
bench_startup/Turbopack RSC/1000 modules	2273.19ms ± 6.68ms	2255.88ms ± 7.83ms	-0.76%
bench_startup/Turbopack SSR/1000 modules	2132.91ms ± 4.03ms	2123.56ms ± 3.76ms	-0.44%

github-actions · 2023-02-17T11:52:50Z

Benchmark for `cdaea61`

Test	Base	PR	%	Significant %
bench_hydration/Turbopack RCC/1000 modules	3911.51ms ± 29.32ms	3718.76ms ± 16.23ms	-4.93%	-2.64%
bench_hydration/Turbopack RSC/1000 modules	3435.63ms ± 13.84ms	3389.75ms ± 8.07ms	-1.34%	-0.06%
bench_hydration/Turbopack SSR/1000 modules	3529.92ms ± 9.10ms	3428.92ms ± 10.87ms	-2.86%	-1.74%
bench_startup/Turbopack SSR/1000 modules	2093.13ms ± 3.23ms	2079.86ms ± 1.72ms	-0.63%	-0.16%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9556.02µs ± 85.24µs	9566.71µs ± 88.05µs	+0.11%
bench_hmr_to_commit/Turbopack RCC/1000 modules	11.21ms ± 0.12ms	11.35ms ± 0.10ms	+1.24%
bench_hmr_to_commit/Turbopack RSC/1000 modules	526.06ms ± 2.37ms	519.74ms ± 1.23ms	-1.20%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9692.70µs ± 63.14µs	9656.92µs ± 86.36µs	-0.37%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8590.24µs ± 81.76µs	8579.56µs ± 79.45µs	-0.12%
bench_hmr_to_eval/Turbopack RCC/1000 modules	10.21ms ± 0.07ms	10.32ms ± 0.10ms	+1.09%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8639.90µs ± 57.20µs	8669.70µs ± 93.30µs	+0.34%
bench_hydration/Turbopack RCC/1000 modules	3911.51ms ± 29.32ms	3718.76ms ± 16.23ms	-4.93%	-2.64%
bench_hydration/Turbopack RSC/1000 modules	3435.63ms ± 13.84ms	3389.75ms ± 8.07ms	-1.34%	-0.06%
bench_hydration/Turbopack SSR/1000 modules	3529.92ms ± 9.10ms	3428.92ms ± 10.87ms	-2.86%	-1.74%
bench_startup/Turbopack CSR/1000 modules	2704.35ms ± 6.57ms	2700.12ms ± 13.01ms	-0.16%
bench_startup/Turbopack RCC/1000 modules	2284.07ms ± 4.64ms	2277.67ms ± 3.34ms	-0.28%
bench_startup/Turbopack RSC/1000 modules	2210.39ms ± 7.18ms	2233.66ms ± 8.64ms	+1.05%
bench_startup/Turbopack SSR/1000 modules	2093.13ms ± 3.23ms	2079.86ms ± 1.72ms	-0.63%	-0.16%

crates/turbo-tasks-memory/src/memory_backend.rs

crates/turbo-tasks-memory/src/scope.rs

crates/turbo-tasks-memory/src/task.rs

crates/turbo-tasks/src/manager.rs

This reverts commit f6636a0.

…e type system

github-actions · 2023-02-17T16:27:32Z

Benchmark for `0cafd7c`

Test	Base	PR	%	Significant %
bench_hydration/Turbopack SSR/1000 modules	3589.82ms ± 21.72ms	3502.88ms ± 11.86ms	-2.42%	-0.56%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.27ms ± 0.04ms	10.38ms ± 0.12ms	+1.05%
bench_hmr_to_commit/Turbopack RCC/1000 modules	12.05ms ± 0.14ms	12.12ms ± 0.16ms	+0.60%
bench_hmr_to_commit/Turbopack RSC/1000 modules	520.73ms ± 1.37ms	522.13ms ± 1.18ms	+0.27%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.35ms ± 0.09ms	10.38ms ± 0.10ms	+0.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9305.41µs ± 82.95µs	9322.54µs ± 101.29µs	+0.18%
bench_hmr_to_eval/Turbopack RCC/1000 modules	11.09ms ± 0.15ms	11.17ms ± 0.15ms	+0.68%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9231.12µs ± 73.61µs	9291.51µs ± 94.04µs	+0.65%
bench_hydration/Turbopack RCC/1000 modules	3931.68ms ± 26.07ms	3840.01ms ± 25.58ms	-2.33%
bench_hydration/Turbopack RSC/1000 modules	3488.74ms ± 12.41ms	3455.85ms ± 10.54ms	-0.94%
bench_hydration/Turbopack SSR/1000 modules	3589.82ms ± 21.72ms	3502.88ms ± 11.86ms	-2.42%	-0.56%
bench_startup/Turbopack CSR/1000 modules	2780.21ms ± 8.22ms	2749.05ms ± 10.74ms	-1.12%
bench_startup/Turbopack RCC/1000 modules	2339.14ms ± 4.51ms	2336.32ms ± 1.98ms	-0.12%
bench_startup/Turbopack RSC/1000 modules	2261.57ms ± 9.77ms	2255.75ms ± 8.65ms	-0.26%
bench_startup/Turbopack SSR/1000 modules	2134.01ms ± 4.14ms	2134.56ms ± 3.96ms	+0.03%

Performance Improvements: * vercel/turborepo#3849 Misc: * vercel/turborepo#3850 * vercel/turborepo#3861 * vercel/turborepo#3823

# Performance Improvements: * vercel/turborepo#3849 * vercel/turborepo#3878 * vercel/turborepo#3864 # Misc: * vercel/turborepo#3847 * vercel/turborepo#3865 * vercel/turborepo#3850 * vercel/turborepo#3861 * vercel/turborepo#3823 * vercel/turborepo#3882 # Contributing * Update profiling instructions for macOS ([#3837](vercel/turborepo#3837))

)

turbo-orchestrator bot added the team: turbopack label Feb 17, 2023

vercel bot deployed to Preview – turbo-site February 17, 2023 00:10 View deployment

sokra force-pushed the sokra/perf-scopes branch from d08ee17 to 4494954 Compare February 17, 2023 10:35

vercel bot deployed to Preview – turbo-site February 17, 2023 10:35 View deployment

sokra marked this pull request as ready for review February 17, 2023 11:39

sokra requested a review from a team as a code owner February 17, 2023 11:39

alexkirsz approved these changes Feb 17, 2023

View reviewed changes

sokra added 18 commits February 17, 2023 16:08

improve task scope optimization

2147685

fix incorrect scope removals

cc06b45

remove depth tracking

c0d42d4

inline with_scope/task

c395c02

refactor collectibles reading to use turbo-tasks functions for caching

c3e839f

avoid stringifying every task

3512014

read collectibles task starts root scoped

9d9d411

use read collectibles task in table view

0f05b2f

optimize scopes when adding children too

ece00fa

add inline_add/remove_to/from_scope features

c5f0b2d

reduce function count

ae800b5

Revert "reduce function count"

92af6b9

This reverts commit f6636a0.

reduce ContentSource::get resolve tasks

91ab6a1

add Unused wrapper to differ fresh task id from used task ids with th…

1b87155

…e type system

tuple to struct for readablility

a900380

add comment

a96c59b

move optimization decision into a separate function

e6865f0

improve readablility

2f850d1

sokra force-pushed the sokra/perf-scopes branch from 4494954 to 2f850d1 Compare February 17, 2023 15:10

sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 17, 2023

vercel bot deployed to Preview – turbo-site February 17, 2023 15:10 View deployment

kodiakhq bot merged commit b2f9219 into main Feb 17, 2023

kodiakhq bot deleted the sokra/perf-scopes branch February 17, 2023 15:44

sokra mentioned this pull request Feb 21, 2023

update turbopack vercel/next.js#46202

Closed

wbinnssmith added a commit to vercel/next.js that referenced this pull request Feb 21, 2023

Update Turbopack to turbopack-230221.3

c2e7305

Performance Improvements: * vercel/turborepo#3849 Misc: * vercel/turborepo#3850 * vercel/turborepo#3861 * vercel/turborepo#3823

wbinnssmith mentioned this pull request Feb 21, 2023

Update Turbopack to turbopack-230221.3 (#46209 vercel/next.js#46209

Merged

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024

improve performance of TaskScopes and collectibes (vercel/turborepo#3849

91e44b5

)

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024

improve performance of TaskScopes and collectibes (vercel/turborepo#3849

bb2aeb7

)

ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024

improve performance of TaskScopes and collectibes (vercel/turborepo#3849

dcb5649

)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve performance of TaskScopes and collectibes #3849

improve performance of TaskScopes and collectibes #3849

sokra commented Feb 17, 2023

vercel bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

github-actions bot commented Feb 17, 2023

improve performance of TaskScopes and collectibes #3849

improve performance of TaskScopes and collectibes #3849

Conversation

sokra commented Feb 17, 2023

vercel bot commented Feb 17, 2023 • edited Loading

github-actions bot commented Feb 17, 2023 • edited Loading

⚠️ CI failed ⚠️

github-actions bot commented Feb 17, 2023

Benchmark for 109df2c

github-actions bot commented Feb 17, 2023

Benchmark for cdaea61

github-actions bot commented Feb 17, 2023

Benchmark for 0cafd7c

vercel bot commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023 •

edited

Loading

Benchmark for `109df2c`

Benchmark for `cdaea61`

Benchmark for `0cafd7c`