fix consistency issue with reading collectibles #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connect original task to collectibles reading to fix strongly consistency move read collectibles tasks to task and scope instead of a separate cache reading collectibles is no longer strongly consistent by default, it's opt-in now
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
Benchmark for 95b72b1Click to view benchmark
|
Benchmark for bdaf28b
Click to view full benchmark
|
alexkirsz
approved these changes
Feb 21, 2023
| "Scope collectibles not correctly cleaned up: {:?}", | ||
| state.collectibles | ||
| ); | ||
| // TODO read_collectibles_tasks need to be cleaned up |
There was a problem hiding this comment.
Is there a linear issue for this?
There was a problem hiding this comment.
sokra
added
the
pr: automerge
kodiakhq
bot
deleted the
sokra/web-612-fix-consistency-issue-with-collectibles
branch
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
# Performance Improvements * improve performance of TaskScopes and collectibes ([#3849](https://github.com/vercel/turbo/pull3849/)) * fix consistency issue with reading collectibles ([#3878](vercel/turborepo#3878)) * change to NoHashHasher for ID keys ([#3864](https://github.com/vercel/turbo/pull3864/)) # Bug Fixes * strip UNC prefix on windows paths ([#3847](https://github.com/vercel/turbo/pull3847/)) * make error overlay message scrollable ([#3861](vercel/turborepo#3861)) * alias @swc/helpers to the version within next.js ([#3865](https://github.com/vercel/turbo/pull3865/)) * add possible unknown mutation to objects and arrays ([#3882](vercel/turborepo#3882)) # Contributing * Update profiling instructions for macOS ([#3837](https://github.com/vercel/turbo/pull3837/))
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
# Performance Improvements: * vercel/turborepo#3849 * vercel/turborepo#3878 * vercel/turborepo#3864 # Misc: * vercel/turborepo#3847 * vercel/turborepo#3865 * vercel/turborepo#3850 * vercel/turborepo#3861 * vercel/turborepo#3823 * vercel/turborepo#3882 # Contributing * Update profiling instructions for macOS ([#3837](vercel/turborepo#3837))
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
connect original task to collectibles reading to fix strongly consistency move read collectibles tasks to task and scope instead of a separate cache reading collectibles is no longer strongly consistent by default, it's opt-in now
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
connect original task to collectibles reading to fix strongly consistency move read collectibles tasks to task and scope instead of a separate cache reading collectibles is no longer strongly consistent by default, it's opt-in now
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
connect original task to collectibles reading to fix strongly consistency move read collectibles tasks to task and scope instead of a separate cache reading collectibles is no longer strongly consistent by default, it's opt-in now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect original task to collectibles reading to fix strongly consistency
move read collectibles tasks to task and scope instead of a separate cache
reading collectibles is no longer strongly consistent by default, it's opt-in now