Export downloadedBinPath in turbo postinstall #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/2itHNiPFgVoWxpimnxUQvHU91UKf |
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
This implements `.env` loading by taking advantage of the [dotenvy](https://docs.rs/dotenvy/latest/dotenvy/) crate. Unfortunately, this isn't as featureful as the npm `dotenv`, lacking `FOO=${BAR:-default}` default support (this might be important), `FOO=${MAYBE_UNDEFINED:-${BAR-:default}}` nested fallbacks, and `` FOO=`backtick` `` support. This is then converted into a series of assignments for the client code. This is run before any of the user code. ```js const env = process.env; env["FOO"] = "bar"; //... ``` - - - TODO: - [x] ~~Replace `process.env.FOO`/`process.env["FOO"]` during chunk compilation~~ - using a runtime module speeds up HMR because the code doesn't need to be recompiled. - [x] I don't actually know how to test server rendering, so I assume it works but haven't verified.
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This implements `.env` loading by taking advantage of the [dotenvy](https://docs.rs/dotenvy/latest/dotenvy/) crate. Unfortunately, this isn't as featureful as the npm `dotenv`, lacking `FOO=${BAR:-default}` default support (this might be important), `FOO=${MAYBE_UNDEFINED:-${BAR-:default}}` nested fallbacks, and `` FOO=`backtick` `` support. This is then converted into a series of assignments for the client code. This is run before any of the user code. ```js const env = process.env; env["FOO"] = "bar"; //... ``` - - - TODO: - [x] ~~Replace `process.env.FOO`/`process.env["FOO"]` during chunk compilation~~ - using a runtime module speeds up HMR because the code doesn't need to be recompiled. - [x] I don't actually know how to test server rendering, so I assume it works but haven't verified.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This implements `.env` loading by taking advantage of the [dotenvy](https://docs.rs/dotenvy/latest/dotenvy/) crate. Unfortunately, this isn't as featureful as the npm `dotenv`, lacking `FOO=${BAR:-default}` default support (this might be important), `FOO=${MAYBE_UNDEFINED:-${BAR-:default}}` nested fallbacks, and `` FOO=`backtick` `` support. This is then converted into a series of assignments for the client code. This is run before any of the user code. ```js const env = process.env; env["FOO"] = "bar"; //... ``` - - - TODO: - [x] ~~Replace `process.env.FOO`/`process.env["FOO"]` during chunk compilation~~ - using a runtime module speeds up HMR because the code doesn't need to be recompiled. - [x] I don't actually know how to test server rendering, so I assume it works but haven't verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.