Move http cache writing to cacheitem. #4919
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
nathanhammond
force-pushed
the
cache-http-write
branch
from
d384f5e
to
a220a80
Compare
| @@ -31,7 +31,7 @@ type CacheItem struct { | |||
| tw *tar.Writer | |||
| zw io.WriteCloser | |||
| fileBuffer *bufio.Writer | |||
| handle io.Reader | |||
| handle interface{} | |||
There was a problem hiding this comment.
Caches are Reader | Writer | Closer but you can't express that in Go. So this goes to interface{} and each place that needs it does a type assertion.
#4634 made this partially generic, this finishes the work.
| // log.Printf("caching file %v", file) | ||
| if err := cache.storeFile(tw, file); err != nil { | ||
| log.Printf("[ERROR] Error uploading artifact %s to HTTP cache due to: %s", file, err) | ||
| // TODO(jaredpalmer): How can we cancel the request at this point? |
There was a problem hiding this comment.
This is fixed by using the channel. Previously failing here didn't actually blow up the artifact.
| } | ||
| } | ||
| } | ||
| func (cache *httpCache) write(w io.WriteCloser, anchor turbopath.AbsoluteSystemPath, files []turbopath.AnchoredSystemPath, cacheErrorChan chan error) { |
There was a problem hiding this comment.
This is now 1:1 with cache_fs's implementation.
nathanhammond
force-pushed
the
cache-http-write
branch
17 times, most recently
from
ffb93b6
to
c82a628
Compare
nathanhammond
force-pushed
the
cache-http-write
branch
3 times, most recently
from
528d6fd
to
b1f9352
Compare
nathanhammond
force-pushed
the
cache-http-write
branch
from
b1f9352
to
d90427e
Compare
|
The CI test run that confirms cross-platform compat for cacheitem is here: https://github.com/nathanhammond/turbo/actions/runs/5002277231 |
The HTTP cache creates its own tar files that aren't
cacheitem. This migrates them to usecacheitem, same as filesystem cache.