Hotfix for 1.9.9 #5064
Closed
Hotfix for 1.9.9 #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Turbobot <turbobot@vercel.com>
### Description Fixes #5025 In Go code we would shut down the daemon whenever the repository root was removed. This PR adds that logic back by watching the root and exiting the daemon if the root is removed. ### Testing Instructions Added unit test. Follow instructions in reproduction repository in `uncurated-tests/turborepo-netflix-cache-repro` --------- Co-authored-by: Alexander Lyon <arlyon@me.com> Co-authored-by: Chris Olszewski <Chris Olszewski>
turbo-orchestrator
bot
added
pkg: create-turbo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
tknickman
approved these changes
May 22, 2023
### Description Add a short delay to our repo root removal to ensure that we are watching the config flush directory before we attempt to flush it. This should be a super short lived hack ### Testing Instructions CI Co-authored-by: Chris Olszewski <Chris Olszewski>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Turbobot turbobot@vercel.com### Description
Hotfix branch from
77277af34b2ba7642e11edf27a458e4e0e4ca66e, same place1.9.8branched off of.Includes:
1.9.8version bumpTesting Instructions
CI