Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put ESM in strict mode #6270

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Put ESM in strict mode #6270

merged 2 commits into from
Oct 25, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 25, 2023 •
edited by padmaia
Loading

Description

Put ESM in strict mode

Testing Instructions

Closes WEB-1853

@sokra sokra requested a review from a team as a code owner October 25, 2023 05:17
@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 6:10am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 6:10am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 6:10am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 6:10am

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for c1a473a

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 63.20ms ± 3.79ms 63.57ms ± 4.59ms +0.59%
bench_hmr_to_eval/Turbopack CSR/1000 modules 63.15ms ± 4.91ms 63.83ms ± 4.72ms +1.08%
bench_startup/Turbopack CSR/1000 modules 1043.32ms ± 1.84ms 1046.15ms ± 7.44ms +0.27%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

⚠️ Turbopack Benchmark CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for c4eb27d

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules N/A 66.75ms ± 4.76ms N/A N/A
bench_startup/Turbopack CSR/1000 modules 1049.18ms ± 2.50ms 1069.70ms ± 5.83ms +1.96% +0.37%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 67.13ms ± 4.91ms 66.39ms ± 5.24ms -1.10%
bench_hmr_to_eval/Turbopack CSR/1000 modules N/A 66.75ms ± 4.76ms N/A N/A
bench_startup/Turbopack CSR/1000 modules 1049.18ms ± 2.50ms 1069.70ms ± 5.83ms +1.96% +0.37%

@sokra sokra merged commit 51b4769 into main Oct 25, 2023
48 of 51 checks passed
@sokra sokra deleted the sokra/use-strict branch October 25, 2023 06:34
@sokra sokra mentioned this pull request Oct 25, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Oct 25, 2023
@sokra @kodiakhq
update turbopack (#57420)
5f0cfd4 
* vercel/turborepo#6269 <!-- Tobias Koppers - Upload
data even for non-scheduled runs -->
* vercel/turborepo#6270 <!-- Tobias Koppers - Put
ESM in strict mode -->

Closes WEB-1855

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Put ESM in strict mode (vercel/turborepo#6270)
81e0103 
### Description

Put ESM in strict mode

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1853
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Put ESM in strict mode (vercel/turborepo#6270)
0fc179a 
### Description

Put ESM in strict mode

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1853
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Put ESM in strict mode (vercel/turborepo#6270)
1856233 
### Description

Put ESM in strict mode

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes WEB-1853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@ForsakenHarmony ForsakenHarmony Awaiting requested review from ForsakenHarmony

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @jridgewell