Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Merge LazyIssueSource into IssueSource #6433

Merged
merged 12 commits into from
Nov 13, 2023
Merged

refactor: Merge LazyIssueSource into IssueSource #6433

merged 12 commits into from
Nov 13, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 13, 2023 •
edited by padmaia
Loading

Description

This is required for #5737

Testing Instructions

Closes PACK-1953

@kdy1 kdy1 self-assigned this Nov 13, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44pm
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 10:44pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2023 10:44pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@kdy1 kdy1 requested a review from sokra November 13, 2023 21:28
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 1fa1831

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 1162.77ms ± 8.09ms 1123.70ms ± 7.08ms -3.36% -0.76%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 21.63ms ± 0.85ms 21.60ms ± 0.83ms -0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.26ms ± 0.86ms 21.26ms ± 0.85ms -0.04%
bench_startup/Turbopack CSR/1000 modules 1162.77ms ± 8.09ms 1123.70ms ± 7.08ms -3.36% -0.76%

@kdy1 kdy1 marked this pull request as ready for review November 13, 2023 21:46
@kdy1 kdy1 requested a review from a team as a code owner November 13, 2023 21:46
sokra
sokra approved these changes Nov 13, 2023
View reviewed changes
crates/turbopack-core/src/issue/mod.rs Outdated Show resolved Hide resolved
kdy1 and others added 2 commits November 14, 2023 07:42
@kdy1 @sokra
Update crates/turbopack-core/src/issue/mod.rs
ea28cdc 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@kdy1
fix
d1321c1
@kdy1 kdy1 added the pr: automerge Kodiak will merge these automatically after checks pass label Nov 13, 2023
@kodiakhq kodiakhq bot merged commit 2c629e3 into main Nov 13, 2023
49 checks passed
@kodiakhq kodiakhq bot deleted the kdy1/issue-source branch November 13, 2023 22:56
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for 0171261

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.00ms ± 0.88ms 22.02ms ± 0.87ms +0.09%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.62ms ± 0.85ms 21.75ms ± 0.90ms +0.62%
bench_startup/Turbopack CSR/1000 modules 1169.92ms ± 6.85ms 1171.16ms ± 10.16ms +0.11%

@kdy1 kdy1 mentioned this pull request Nov 13, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Nov 15, 2023
@kdy1
Update turbopack (#58408)
f99242b 
* vercel/turborepo#6424 
* vercel/turborepo#6433 

Closes PACK-1967
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1 @sokra
refactor: Merge LazyIssueSource into IssueSource (vercel/turborep…
ac69f9c 
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1 @sokra
refactor: Merge LazyIssueSource into IssueSource (vercel/turborep…
9acd6d5 
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1 @sokra
refactor: Merge LazyIssueSource into IssueSource (vercel/turborep…
9450777 
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees

@kdy1 kdy1

Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @jridgewell @sokra