Revert "revert auth json (#6883)" #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d965c4c.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
chris-olszewski
approved these changes
Jan 4, 2024
tknickman
approved these changes
Jan 4, 2024
Zertsov
added a commit
that referenced
this pull request
Jan 5, 2024
This reverts commit d965c4c. Basically putting back `auth.json` stuff. Build Turborepo Closes TURBO-1993
Zertsov
added a commit
that referenced
this pull request
Jan 10, 2024
This reverts commit d965c4c. Basically putting back `auth.json` stuff. Build Turborepo Closes TURBO-1993
chris-olszewski
added a commit
that referenced
this pull request
Jan 18, 2024
chris-olszewski
added a commit
that referenced
this pull request
Jan 19, 2024
### Description Given current staffing and the fact that the `auth.json` isn't a big feature for the next minor release we want to get more testing to make sure that all of our existing authentication strategies still work with `auth.json`. At the moment `TURBO_TOKEN` isn't respected, this PR should fix that. ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ TURBO_TOKEN=*** turbo_dev build --filter=docs --remote-only --output-logs new-only WARNING no caches are enabled ... ``` This is a revert of the following PRs - #6880 - #6889 - #6927 which make up all of the usage of `auth.json`. ### Testing Instructions Existing tests and 👀 making sure that I reverted everything correctly Make sure that setting `TURBO_TOKEN` works as expected: ``` [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev info | head -n 3 You are not logged in 44 packages found in workspace [0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ TURBO_TOKEN=*** turbo_dev build --filter=docs --remote-only --output-logs new-only • Packages in scope: docs • Running build in 1 packages • Remote caching enabled @turbo/workspaces:build: cache hit (outputs already on disk), suppressing logs 01ead40ee62658af docs:rss: cache hit, suppressing logs c569e716da69384d docs:schema: cache hit, suppressing logs c7438141455c2a98 @turbo/gen:build: cache hit, suppressing logs e0ef70531aac79d7 docs:build: cache hit (outputs already on disk), suppressing logs 9e268e56e4cb8842 Tasks: 5 successful, 5 total Cached: 5 cached, 5 total Time: 1.01s >>> FULL TURBO ``` Closes TURBO-2061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d965c4c.
Description
Basically putting back
auth.jsonstuff.Testing Instructions
Build Turborepo
Closes TURBO-1993