Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(turbopack): Use different title for non-parsing issues #7421

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 20, 2024

Description

We shared Handler instance, and thus we were using Parsing ecmascript source code failed even for non-parsing issues.

Testing Instructions

next.js counterpart: vercel/next.js#62259

Closes PACK-2538

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 3:22pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 22, 2024 3:22pm

Copy link
Contributor

github-actions bot commented Feb 20, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Feb 20, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 marked this pull request as ready for review February 20, 2024 02:04
@kdy1 kdy1 requested a review from a team as a code owner February 20, 2024 02:04
Copy link
Contributor

✅ This change can build next-swc

crates/turbopack-ecmascript/src/parse.rs Outdated Show resolved Hide resolved
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@kdy1 kdy1 merged commit 8b338f7 into main Feb 22, 2024
48 of 49 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2538 branch February 22, 2024 15:20
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 26, 2024
* vercel/turbo#7437 <!-- Tobias Koppers - report
relative start/end and fix start time for events -->
* vercel/turbo#7446 <!-- Tobias Koppers - allow
to aggregate all spans -->
* vercel/turbo#6651 <!-- max -
fix(postcss_configs): support for resolve `postcss.config.json` file -->
* vercel/turbo#7448 <!-- Leah - chore: remove
"rust" npm package -->
* vercel/turbo#7436 <!-- Leah -
refactor(turbo-tasks-fs): move file watching into separate file -->
* vercel/turbo#7396 <!-- Donny/강동윤 -
feat(turbopack): Apply critical ES lint rules -->
* vercel/turbo#7421 <!-- Donny/강동윤 -
fix(turbopack): Use different title for non-parsing issues -->
* vercel/turbo#7501 <!-- Tobias Koppers -
Tracing: Report progress on initial read -->
* vercel/turbo#7508 <!-- Donny/강동윤 -
fix(turbopack): Fix CSS Modules of turbopack in swc mode -->
* vercel/turbo#7424 <!-- Donny/강동윤 -
fix(turbopack): Analyze for-of stmts to allow using `sharp` -->
* vercel/turbo#7510 <!-- Tobias Koppers - dedupe
primary_modules to avoid deduping in chunking, reduce memory usage -->
* vercel/turbo#7509 <!-- Tobias Koppers - split
graph_node_to_referenced_nodes into cacheable and non-cacheable parts
-->
* vercel/turbo#7516 <!-- Tobias Koppers - fix
ignore in package.json -->
* vercel/turbo#7500 <!-- Tobias Koppers - add
span count to trace-server -->
* vercel/turbo#7507 <!-- Donny/강동윤 -
fix(turbopack): Fix CSS module purity validator -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants