Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe primary_modules to avoid deduping in chunking, reduce memory usage #7510

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 23, 2024

Description

This allows to avoid a clone into an IndexSet in graph_node_to_referenced_nodes, so improves performance and avoids temporary memory consumption.

Testing Instructions

Closes PACK-2586

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 9:25am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-gatsby-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-native-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-svelte-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
examples-vite-web ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am
turbo-site ⬜️ Ignored (Inspect) Feb 23, 2024 9:25am

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Feb 23, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit e26e25b into main Feb 23, 2024
51 of 53 checks passed
@sokra sokra deleted the sokra/reduce-memory branch February 23, 2024 12:24
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 26, 2024
* vercel/turbo#7437 <!-- Tobias Koppers - report
relative start/end and fix start time for events -->
* vercel/turbo#7446 <!-- Tobias Koppers - allow
to aggregate all spans -->
* vercel/turbo#6651 <!-- max -
fix(postcss_configs): support for resolve `postcss.config.json` file -->
* vercel/turbo#7448 <!-- Leah - chore: remove
"rust" npm package -->
* vercel/turbo#7436 <!-- Leah -
refactor(turbo-tasks-fs): move file watching into separate file -->
* vercel/turbo#7396 <!-- Donny/강동윤 -
feat(turbopack): Apply critical ES lint rules -->
* vercel/turbo#7421 <!-- Donny/강동윤 -
fix(turbopack): Use different title for non-parsing issues -->
* vercel/turbo#7501 <!-- Tobias Koppers -
Tracing: Report progress on initial read -->
* vercel/turbo#7508 <!-- Donny/강동윤 -
fix(turbopack): Fix CSS Modules of turbopack in swc mode -->
* vercel/turbo#7424 <!-- Donny/강동윤 -
fix(turbopack): Analyze for-of stmts to allow using `sharp` -->
* vercel/turbo#7510 <!-- Tobias Koppers - dedupe
primary_modules to avoid deduping in chunking, reduce memory usage -->
* vercel/turbo#7509 <!-- Tobias Koppers - split
graph_node_to_referenced_nodes into cacheable and non-cacheable parts
-->
* vercel/turbo#7516 <!-- Tobias Koppers - fix
ignore in package.json -->
* vercel/turbo#7500 <!-- Tobias Koppers - add
span count to trace-server -->
* vercel/turbo#7507 <!-- Donny/강동윤 -
fix(turbopack): Fix CSS module purity validator -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants