chore(Turborepo): move test filesystem setup into test code #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
gsoltis
requested review from
tknickman,
arlyon and
chris-olszewski
and removed request for
a team and
arlyon
chris-olszewski
requested changes
Mar 4, 2024
| @@ -402,14 +415,16 @@ mod tests { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_closing() { | |||
| let (_, temp_dir) = temp_dir(); | |||
There was a problem hiding this comment.
Careful with this, _ will cause the var to be dropped immediately vs _tmp which will drop when it goes out of scope.
Suggested change
| let (_, temp_dir) = temp_dir(); | |
| let (_, temp_dir) = temp_dir(); |
There was a problem hiding this comment.
Oh huh, I didn't realize _ was special. Sure enough: https://doc.rust-lang.org/beta/nightly-rustc/rustc_lint/let_underscore/static.LET_UNDERSCORE_DROP.html#:~:text=Statements%20which%20assign%20an%20expression,duration%20of%20an%20entire%20scope.
Good catch.
gsoltis
force-pushed
the
03-01-chore_Turborepo_move_test_filesystem_setup_into_test_code
branch
from
014f3b9
to
2591d2f
Compare
chris-olszewski
approved these changes
Mar 4, 2024
gsoltis
force-pushed
the
03-01-chore_Turborepo_move_test_filesystem_setup_into_test_code
branch
from
2591d2f
to
9ed72d0
Compare
gsoltis
force-pushed
the
03-01-chore_Turborepo_move_test_filesystem_setup_into_test_code
branch
from
9ed72d0
to
630ad75
Compare
gsoltis
deleted the
03-01-chore_Turborepo_move_test_filesystem_setup_into_test_code
branch
kodiakhq bot
added a commit
to weareinreach/TransMascFutures
that referenced
this pull request
Mar 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.11.24` -> `20.11.25`](https://renovatebot.com/diffs/npm/@types%2fnode/20.11.24/20.11.25) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.63` -> `18.2.64`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.63/18.2.64) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [chromatic](https://www.chromatic.com) ([source](https://togithub.com/chromaui/chromatic-cli)) | [`11.0.1` -> `11.0.4`](https://renovatebot.com/diffs/npm/chromatic/11.0.1/11.0.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-turbo](https://togithub.com/vercel/turbo) ([source](https://togithub.com/vercel/turbo/tree/HEAD/packages/eslint-plugin-turbo)) | [`1.12.4` -> `1.12.5`](https://renovatebot.com/diffs/npm/eslint-plugin-turbo/1.12.4/1.12.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [react-i18next](https://togithub.com/i18next/react-i18next) | [`14.0.5` -> `14.0.8`](https://renovatebot.com/diffs/npm/react-i18next/14.0.5/14.0.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`1.12.4` -> `1.12.5`](https://renovatebot.com/diffs/npm/turbo/1.12.4/1.12.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/TypeScript)) | [`5.3.3` -> `5.4.2`](https://renovatebot.com/diffs/npm/typescript/5.3.3/5.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chromaui/chromatic-cli (chromatic)</summary> ### [`v11.0.4`](https://togithub.com/chromaui/chromatic-cli/blob/HEAD/CHANGELOG.md#v1104-Wed-Mar-06-2024) [Compare Source](https://togithub.com/chromaui/chromatic-cli/compare/v11.0.3...v11.0.4) ##### 🐛 Bug Fix - Do not prompt to install chromatic script during E2E builds [#​941](https://togithub.com/chromaui/chromatic-cli/pull/941) ([@​tevanoff](https://togithub.com/tevanoff)) ##### Authors: 1 - Todd Evanoff ([@​tevanoff](https://togithub.com/tevanoff)) *** ### [`v11.0.3`](https://togithub.com/chromaui/chromatic-cli/blob/HEAD/CHANGELOG.md#v1103-Wed-Mar-06-2024) [Compare Source](https://togithub.com/chromaui/chromatic-cli/compare/v11.0.2...v11.0.3) ##### 🐛 Bug Fix - Display full error message when storybookBaseDir is invalid [#​932](https://togithub.com/chromaui/chromatic-cli/pull/932) ([@​andrewortwein](https://togithub.com/andrewortwein)) ##### Authors: 1 - Andrew Ortwein ([@​andrewortwein](https://togithub.com/andrewortwein)) *** ### [`v11.0.2`](https://togithub.com/chromaui/chromatic-cli/blob/HEAD/CHANGELOG.md#v1102-Tue-Mar-05-2024) [Compare Source](https://togithub.com/chromaui/chromatic-cli/compare/v11.0.1...v11.0.2) ##### 🐛 Bug Fix - Fix support for boolean value to `junitReport` option [#​937](https://togithub.com/chromaui/chromatic-cli/pull/937) ([@​thafryer](https://togithub.com/thafryer)) ##### Authors: 1 - Jarel Fryer ([@​thafryer](https://togithub.com/thafryer)) *** </details> <details> <summary>vercel/turbo (eslint-plugin-turbo)</summary> ### [`v1.12.5`](https://togithub.com/vercel/turbo/releases/tag/v1.12.5): Turborepo v1.12.5 [Compare Source](https://togithub.com/vercel/turbo/compare/v1.12.4...v1.12.5) #### What's Changed ##### Docs - Name the file in Prisma doc. by [@​anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#7426 - chore(docs): update github actions versions to support node 20 by [@​robinsmith-source](https://togithub.com/robinsmith-source) in [vercel/turbo#7434 - chore: update docs to no longer suggest verbosity for `--profile` by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7521 - Add version to package in internal packages docs for yarn by [@​loctn](https://togithub.com/loctn) in [vercel/turbo#7626 ##### create-turbo - release(turborepo): 1.12.4 by [@​github-actions](https://togithub.com/github-actions) in [vercel/turbo#7383 ##### [@​turbo/repository](https://togithub.com/turbo/repository) - chore(Turborepo): bump versions in prep for a release by [@​gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7385 - refactor(turborepo): Package Detection by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7549 - feat([@​turbo/repository](https://togithub.com/turbo/repository)): return dependencies in graph by [@​mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7616 - chore([@​turbo/repository](https://togithub.com/turbo/repository)): bump version to 0.0.1-canary.8 by [@​mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7636 ##### Examples - fix(examples): basic generator by [@​dangbt](https://togithub.com/dangbt) in [vercel/turbo#7400 - Remove barrel file from design-system-example by [@​anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#7580 - Dependabot updates for examples. by [@​anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#7615 - Bug fix on with-npm by [@​zsh77](https://togithub.com/zsh77) in [vercel/turbo#7587 - dev script of ui package in example with rollup by [@​zsh77](https://togithub.com/zsh77) in [vercel/turbo#7550 - Cleanup of with-vite example by [@​zsh77](https://togithub.com/zsh77) in [vercel/turbo#7585 - Cleanup of with-yarn example by [@​zsh77](https://togithub.com/zsh77) in [vercel/turbo#7589 - Guarantee typescript-eslint parser resolving. by [@​anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#7634 ##### Changelog - perf: parse and walk globs in parallel by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7244 - fix: do better validation for existing tokens by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7358 - chore(ci): remove Makefile targets to build Go binaries by [@​mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7389 - add error enum to `turborepo-dirs` by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7277 - fix: Clippy errors by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7392 - docs: Refresh daemon documentation by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7386 - Break up Client trait by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7387 - chore(turbo): delete unused goreleaser configs by [@​mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7393 - Improve daemon startup times by [@​arlyon](https://togithub.com/arlyon) in [vercel/turbo#7322 - fix: reading output from orphan process by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7402 - Add optionalwatch cookie support by [@​arlyon](https://togithub.com/arlyon) in [vercel/turbo#7379 - chore: add force flag to login command by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7378 - Audit daemon error paths and ensure we are doing everything we can to handle by [@​arlyon](https://togithub.com/arlyon) in [vercel/turbo#7334 - chore: lower log level for noisy crates by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7439 - chore: Rename daemon code by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7440 - fix: support yarn4 semver resolutions by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7442 - fix: More robust token validation by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7407 - chore: Change daemon log location to be in repo by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7468 - chore: remove unnecessary result on join_unix_path by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7506 - chore: remove unused features from config crate by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7531 - feat: task table widget by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7470 - fix: Remove extra login popup for Vercel by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7469 - feat(turborepo): Convert even more errors by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7513 - fix: correctly call teams api by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7533 - chore: add read_existing_to_string by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7532 - feat: allow for faux comments at top level of turbo.json by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7546 - fix: Load vercel token into command base by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7545 - fix: support pnpm workspace path aliasing by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7512 - chore: remove unused import from dep_splitter by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7555 - fix: Respect globalDependencies when determining changed packages by [@​NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7557 - feat(Turborepo): Renaming, additional cookiewriter constructor by [@​gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7553 - fix: vercel auth file borks login by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7556 - fix: login success page redirect by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7558 - chore: move logout functionality into auth crate by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7443 - chore: Change to use borrowed path by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7569 - Handle logging story better on daemon by [@​arlyon](https://togithub.com/arlyon) in [vercel/turbo#7526 - fix: sso login duplicate popup by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7575 - chore(Turborepo): refactor telemetry to use turbopath by [@​gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7567 - chore(Turborepo): move test filesystem setup into test code by [@​gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7568 - chore(Turborepo): Switch tests to use filesystem, remove unused generics by [@​gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7610 - fix(cache): fix restoration issues of directories with very long paths by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7628 - chore: vendor vt100 crate by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7591 - fix(cache): restoration symlink by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7633 - fix: reject empty cache dir path by [@​chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7630 - fix: add more caching status tests by [@​Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7574 #### New Contributors - [@​dangbt](https://togithub.com/dangbt) made their first contribution in [vercel/turbo#7400 - [@​robinsmith-source](https://togithub.com/robinsmith-source) made their first contribution in [vercel/turbo#7434 - [@​nnmax](https://togithub.com/nnmax) made their first contribution in [vercel/turbo#6651 - [@​bgw](https://togithub.com/bgw) made their first contribution in [vercel/turbo#7206 - [@​loctn](https://togithub.com/loctn) made their first contribution in [vercel/turbo#7626 - [@​zsh77](https://togithub.com/zsh77) made their first contribution in [vercel/turbo#7587 **Full Changelog**: vercel/turbo@v1.12.4...v1.12.5 </details> <details> <summary>i18next/react-i18next (react-i18next)</summary> ### [`v14.0.8`](https://togithub.com/i18next/react-i18next/blob/HEAD/CHANGELOG.md#1408) [Compare Source](https://togithub.com/i18next/react-i18next/compare/v14.0.7...v14.0.8) - fix: issue [1728](https://togithub.com/i18next/react-i18next/issues/1728) when useSuspense is false and default ns [1731](https://togithub.com/i18next/react-i18next/pull/1731) ### [`v14.0.7`](https://togithub.com/i18next/react-i18next/blob/HEAD/CHANGELOG.md#1407) [Compare Source](https://togithub.com/i18next/react-i18next/compare/v14.0.6...v14.0.7) - try to get rid of internal interpolationOverride handling for Trans component, fixes [1729](https://togithub.com/i18next/react-i18next/issues/1729) ### [`v14.0.6`](https://togithub.com/i18next/react-i18next/blob/HEAD/CHANGELOG.md#1406) [Compare Source](https://togithub.com/i18next/react-i18next/compare/v14.0.5...v14.0.6) - align context handling of Trans component with t function, fixes [1729](https://togithub.com/i18next/react-i18next/issues/1729) </details> <details> <summary>vercel/turbo (turbo)</summary> ### [`v1.12.5`](https://togithub.com/vercel/turbo/compare/v1.12.4...v1.12.5) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.12.4...v1.12.5) </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.4.2`](https://togithub.com/microsoft/TypeScript/releases/tag/v5.4.2): TypeScript 5.4 [Compare Source](https://togithub.com/Microsoft/TypeScript/compare/v5.3.3...v5.4.2) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 5.4.0 (Beta)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.0%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.1 (RC)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.1%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.2 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.2%22+is%3Aclosed+). Downloads are available on: - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday,before 4am on Thursday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #356 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Updated tests to create their own temp directories
Closes TURBO-2497