fix(Turborepo): Handle directory moves in package discovery #7700

gsoltis · 2024-03-11T23:17:38Z

Description

Update timeout on package discovery RPC to be a little more lenient
Handle entire directory moves in and out of the workspaces globs

Testing Instructions

Update package discovery test to handle an entire workspace moving.
Also did some manual verification.

vercel · 2024-03-11T23:17:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-gatsby-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 3:03am
examples-nonmonorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 3:03am
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 3:03am
rust-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 3:03am
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 13, 2024 3:03am

6 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Mar 13, 2024 3:03am

gsoltis · 2024-03-11T23:17:51Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gsoltis and the rest of your teammates on Graphite

github-actions · 2024-03-11T23:18:18Z

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions · 2024-03-11T23:54:02Z

🟢 CI successful 🟢

Thanks

chris-olszewski

Two very minor comments, but otherwise LGTM

chris-olszewski · 2024-03-12T17:18:17Z

crates/turborepo-lib/src/daemon/client.rs

@@ -127,7 +127,7 @@ impl<T> DaemonClient<T> {
    pub async fn discover_packages(&mut self) -> Result<DiscoverPackagesResponse, DaemonError> {
        let req = proto::DiscoverPackagesRequest {};
        let mut req = req.into_request();
-        req.set_timeout(Duration::from_millis(10));
+        req.set_timeout(Duration::from_millis(50));


This feels too high to me. With a debug build doing a local package discovery on the turbo repo takes 30ms.

Changing to 30. Will adjust again in another PR after some additional fixes

crates/turborepo-filewatch/src/package_watcher.rs

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-codegen](https://togithub.com/mmkal/eslint-plugin-codegen) | [`0.26.0` -> `0.28.0`](https://renovatebot.com/diffs/npm/eslint-plugin-codegen/0.26.0/0.28.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-codegen/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-codegen/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-codegen/0.26.0/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-codegen/0.26.0/0.28.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-turbo](https://togithub.com/vercel/turbo) ([source](https://togithub.com/vercel/turbo/tree/HEAD/packages/eslint-plugin-turbo)) | [`1.12.5` -> `1.13.0`](https://renovatebot.com/diffs/npm/eslint-plugin-turbo/1.12.5/1.13.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-turbo/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-turbo/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-turbo/1.12.5/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-turbo/1.12.5/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [turbo](https://turbo.build/repo) ([source](https://togithub.com/vercel/turbo)) | [`1.12.5` -> `1.13.0`](https://renovatebot.com/diffs/npm/turbo/1.12.5/1.13.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/turbo/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/turbo/1.12.5/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/1.12.5/1.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/TypeScript)) | [`5.4.2` -> `5.4.3`](https://renovatebot.com/diffs/npm/typescript/5.4.2/5.4.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/typescript/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/typescript/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/typescript/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/typescript/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mmkal/eslint-plugin-codegen (eslint-plugin-codegen)</summary> ### [`v0.28.0`](https://togithub.com/mmkal/eslint-plugin-codegen/releases/tag/v0.28.0) [Compare Source](https://togithub.com/mmkal/eslint-plugin-codegen/compare/0.27.0...v0.28.0) - only consider codegen/codegen rules [`4aafe14`](https://togithub.com/mmkal/eslint-plugin-codegen/commit/4aafe14) ### [`v0.27.0`](https://togithub.com/mmkal/eslint-plugin-codegen/releases/tag/0.27.0) [Compare Source](https://togithub.com/mmkal/eslint-plugin-codegen/compare/0.26.0...0.27.0) #### What's Changed - generalise markdown-from-jsdoc by [@mmkal](https://togithub.com/mmkal) in [mmkal/eslint-plugin-codegen#25 **Full Changelog**: mmkal/eslint-plugin-codegen@0.26.0...0.27.0 </details> <details> <summary>vercel/turbo (eslint-plugin-turbo)</summary> ### [`v1.13.0`](https://togithub.com/vercel/turbo/releases/tag/v1.13.0): Turborepo v1.13.0 [Compare Source](https://togithub.com/vercel/turbo/compare/v1.12.5...v1.13.0) #### What's Changed ##### Docs - s/the your/the/ by [@steveluscher](https://togithub.com/steveluscher) in [vercel/turbo#7669 - s/mental/model/ by [@steveluscher](https://togithub.com/steveluscher) in [vercel/turbo#7668 - Fix typos in docs & turborepo-lsp by [@Dann1y](https://togithub.com/Dann1y) in [vercel/turbo#7702 - docs: Update testing configuration documentation for clarity by [@sooster910](https://togithub.com/sooster910) in [vercel/turbo#7683 - docs: change texts from lint to type-check by [@devjiwonchoi](https://togithub.com/devjiwonchoi) in [vercel/turbo#7698 - `scan` command doc. by [@anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#6770 - Docs: add references to TURBO_CACHE_DIR environment variable by [@weyert](https://togithub.com/weyert) in [vercel/turbo#7632 - Use hardcoding. by [@anthonyshew](https://togithub.com/anthonyshew) in [vercel/turbo#7792 - docs: document new ui configuration options by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7803 ##### create-turbo - publish 1.13.0-canary.2 to registry by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7787 ##### eslint - Support import.meta.env in eslint-plugin-turbo by [@jamesbvaughan](https://togithub.com/jamesbvaughan) in [vercel/turbo#7781 ##### [@turbo/repository](https://togithub.com/turbo/repository) - fix([@turbo/repository](https://togithub.com/turbo/repository)): Remove custom type so nap can serialize it by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7650 - chore([@turbo/repository](https://togithub.com/turbo/repository)): bump to 0.0.1-canary.9 by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7652 - refactor(turborepo): Renaming -PackageDetector to -PackageChangeMapper by [@NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7655 - chore([@turbo/repository](https://togithub.com/turbo/repository)): show current version when publishing by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7679 - chore([@turbo/repository](https://togithub.com/turbo/repository)): bump to 0.0.1-canary.10 by [@mehulkar](https://togithub.com/mehulkar) in [vercel/turbo#7680 ##### Examples - Bug fix on with-tailwind example by [@zsh77](https://togithub.com/zsh77) in [vercel/turbo#7584 - Improvements on kitchen-sink example by [@zsh77](https://togithub.com/zsh77) in [vercel/turbo#7641 - Bug fix on with rollup by [@zsh77](https://togithub.com/zsh77) in [vercel/turbo#7651 - fix(examples): avoid clearing screen when using vite by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7783 - Bug fix on kitchen-sink example by [@zsh77](https://togithub.com/zsh77) in [vercel/turbo#7624 - fix(ci): fix examples CI check by [@tknickman](https://togithub.com/tknickman) in [vercel/turbo#7801 ##### Changelog - chore: clean up silent flag impl by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7643 - chore: silence lint warnings from vt100 crate by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7647 - chore: rename vendored vt100 crate by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7649 - feat: Add success rate telemetry for login by [@Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7656 - chore(turborepo): Move PackageChangeMappers to turborepo-repository by [@NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7657 - feature: Add invalidate flag to logout by [@Zertsov](https://togithub.com/Zertsov) in [vercel/turbo#7444 - feat: terminal pane component by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7619 - feat: add getter for selected task by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7614 - chore(Turborepo): refactor client side of daemon-backed package discovery by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7644 - fix(turborepo): Logout by [@NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7667 - feat: add scan subcommand by [@arlyon](https://togithub.com/arlyon) in [vercel/turbo#6788 - fix(Turborepo): Fix cookie directory by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7664 - refactor(turborepo): Split up `Run` into `RunBuilder` and `Run` by [@NicholasLYang](https://togithub.com/NicholasLYang) in [vercel/turbo#7681 - chore: generalize log writer by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7678 - chore: generalize cache terminal output by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7701 - feat: add entire screen viewer to vt100 by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7699 - fix(Turborepo): Handle directory moves in package discovery by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7700 - chore(Turborepo): Handle unhandled error case in package discovery by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7703 - feat: ensure PrefixedWriter is line buffered by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7728 - chore(Turborepo): Consolidate Subscriber::watch and setup task by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7714 - feat(Turborepo): add error handling to package discovery process by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7725 - feat: enable new UI by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7733 - fix: retry requests that fail due to timeout or request errors by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7745 - feat: enable env var for preflight by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7754 - chore: add ability to configure TUI via turbo.json by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7755 - Add TURBO_CACHE_DIR env for `--cache-dir` flag by [@weyert](https://togithub.com/weyert) in [vercel/turbo#6294 - fix(ui): properly handle escape codes in persisted output by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7760 - fix(ui): always start tasks by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7758 - feat(Turborepo): handle invalid states in package watching by [@gsoltis](https://togithub.com/gsoltis) in [vercel/turbo#7759 - feat: add ability to configure tasks as interactive by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7767 - feat: enable windows pty by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7780 - chore(ui): add more info to table footer by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7788 - chore: update turbo.json schema for interactive tasks by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7786 - feat(pnpm): respect link-workspace-packages npmrc by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7791 - feat: add ability to control UI via cli arg by [@chris-olszewski](https://togithub.com/chris-olszewski) in [vercel/turbo#7793 - feat: support apple git in scan diagnostic by [@arlyon](https://togithub.com/arlyon) in [vercel/turbo#7740 #### New Contributors - [@steveluscher](https://togithub.com/steveluscher) made their first contribution in [vercel/turbo#7669 - [@Dann1y](https://togithub.com/Dann1y) made their first contribution in [vercel/turbo#7702 - [@sooster910](https://togithub.com/sooster910) made their first contribution in [vercel/turbo#7683 - [@jamesbvaughan](https://togithub.com/jamesbvaughan) made their first contribution in [vercel/turbo#7781 **Full Changelog**: vercel/turbo@v1.12.5...v1.13.0 </details> <details> <summary>vercel/turbo (turbo)</summary> ### [`v1.13.0`](https://togithub.com/vercel/turbo/compare/v1.12.5...v1.13.0) [Compare Source](https://togithub.com/vercel/turbo/compare/v1.12.5...v1.13.0) </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.4.3`](https://togithub.com/microsoft/TypeScript/releases/tag/v5.4.3): TypeScript 5.4.3 [Compare Source](https://togithub.com/Microsoft/TypeScript/compare/v5.4.2...v5.4.3) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 5.4.0 (Beta)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.0%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.1 (RC)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.1%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.2 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.2%22+is%3Aclosed+). - [fixed issues query for Typescript 5.4.3 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.4.3%22+is%3Aclosed+). Downloads are available on: - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday,before 4am on Thursday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #370 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

turbo-orchestrator bot added created-by: turborepo owned-by: turborepo labels Mar 11, 2024

vercel bot deployed to Preview – examples-nonmonorepo March 11, 2024 23:18 View deployment

vercel bot deployed to Preview – turbo-site March 11, 2024 23:18 View deployment

vercel bot deployed to Preview – rust-docs March 11, 2024 23:27 View deployment

gsoltis marked this pull request as ready for review March 12, 2024 01:23

gsoltis requested a review from a team as a code owner March 12, 2024 01:23

gsoltis requested review from mehulkar, chris-olszewski, arlyon and NicholasLYang and removed request for mehulkar March 12, 2024 01:23

gsoltis mentioned this pull request Mar 12, 2024

chore(Turborepo): Handle unhandled error case in package discovery #7703

Merged

chris-olszewski approved these changes Mar 12, 2024

View reviewed changes

gsoltis mentioned this pull request Mar 12, 2024

chore(Turborepo): Consolidate Subscriber::watch and setup task #7714

Merged

gsoltis force-pushed the 03-11-fix_Turborepo_Handle_directory_moves_in_package_discovery branch from 488001f to 3ed7faf Compare March 12, 2024 23:34

vercel bot deployed to Preview – examples-nonmonorepo March 12, 2024 23:36 View deployment

vercel bot deployed to Preview – rust-docs March 12, 2024 23:44 View deployment

fix(Turborepo): Handle directory moves in package discovery

a0b841e

gsoltis force-pushed the 03-11-fix_Turborepo_Handle_directory_moves_in_package_discovery branch from 3ed7faf to a0b841e Compare March 13, 2024 02:53

vercel bot deployed to Preview – examples-nonmonorepo March 13, 2024 02:54 View deployment

vercel bot deployed to Preview – rust-docs March 13, 2024 03:03 View deployment

gsoltis merged commit d0d0662 into main Mar 13, 2024
57 checks passed

gsoltis deleted the 03-11-fix_Turborepo_Handle_directory_moves_in_package_discovery branch March 13, 2024 16:21

gsoltis mentioned this pull request Mar 13, 2024

feat(Turborepo): add error handling to package discovery process #7725

Merged

kdy1 mentioned this pull request Mar 14, 2024

build: Update turbopack vercel/next.js#63273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Turborepo): Handle directory moves in package discovery #7700

fix(Turborepo): Handle directory moves in package discovery #7700

gsoltis commented Mar 11, 2024 •

edited by padmaia

vercel bot commented Mar 11, 2024 •

edited

gsoltis commented Mar 11, 2024 •

edited

github-actions bot commented Mar 11, 2024 •

edited

github-actions bot commented Mar 11, 2024 •

edited

chris-olszewski left a comment

chris-olszewski Mar 12, 2024

gsoltis Mar 12, 2024

fix(Turborepo): Handle directory moves in package discovery #7700

fix(Turborepo): Handle directory moves in package discovery #7700

Conversation

gsoltis commented Mar 11, 2024 • edited by padmaia

Description

Testing Instructions

vercel bot commented Mar 11, 2024 • edited

gsoltis commented Mar 11, 2024 • edited

github-actions bot commented Mar 11, 2024 • edited

🟢 Turbopack Benchmark CI successful 🟢

github-actions bot commented Mar 11, 2024 • edited

🟢 CI successful 🟢

chris-olszewski left a comment

Choose a reason for hiding this comment

chris-olszewski Mar 12, 2024

Choose a reason for hiding this comment

gsoltis Mar 12, 2024

Choose a reason for hiding this comment

gsoltis commented Mar 11, 2024 •

edited by padmaia

vercel bot commented Mar 11, 2024 •

edited

gsoltis commented Mar 11, 2024 •

edited

github-actions bot commented Mar 11, 2024 •

edited

github-actions bot commented Mar 11, 2024 •

edited