Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove experimentalGlobalPassThroughEnv from schema #7799

Closed

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Mar 21, 2024

Description

Remove this from the schema as we currently don't respect it and globalPassThroughEnv has been around for some time.

Testing Instructions

👀 + a quick rg -F 'experimentalGlobalPassThroughEnv' to verify we never actually read this.

Closes TURBO-2678

@chris-olszewski chris-olszewski marked this pull request as ready for review March 21, 2024 15:12
@chris-olszewski chris-olszewski requested a review from a team as a code owner March 21, 2024 15:12
Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:53pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:53pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:53pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:53pm
rust-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 29, 2024 6:53pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:53pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:53pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:53pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:53pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 6:53pm

Copy link
Contributor

github-actions bot commented Mar 21, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 21, 2024

🟢 CI successful 🟢

Thanks

@tknickman
Copy link
Member

Looks like we'll need some test updates as well, but should just be removing the key

@anthonyshew
Copy link
Contributor

Believe this is done now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants