Turbo tasks: Reuse aggregation context and apply queued updates #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue that caused Turbopack to panic with https://github.com/vercel/turbo/blob/04e2a9f0cb9439913975a325ce3eb59b46380ff8/crates/turbo-tasks-memory/src/task/aggregation.rs#L211 When marking a task dirty: - Reuse the aggregation context instead of creating - Apply queued updates
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
kwonoj
approved these changes
Mar 26, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 27, 2024
* vercel/turbo#7797 <!-- Tobias Koppers - fix externals in side-effect optimized modules --> * vercel/turbo#7830 <!-- Tobias Koppers - Avoid showing import map description in resolving issue when there is no import map mapping --> * vercel/turbo#7833 <!-- Tobias Koppers - add next.js trace format --> * vercel/turbo#7835 <!-- Tobias Koppers - correct global start by first start time --> * vercel/turbo#7812 <!-- Will Binns-Smith - Turbopack docs: Fix broken webpack loaders link --> * vercel/turbo#7847 <!-- Will Binns-Smith - Turbo tasks: Reuse aggregation context and apply queued updates --> * vercel/turbo#7840 <!-- Tobias Koppers - add concurrency corrected duration --> * vercel/turbo#7854 <!-- Tobias Koppers - fix size_hint on count hash set -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue that caused Turbopack to panic with
turbo/crates/turbo-tasks-memory/src/task/aggregation.rs
Line 211 in 04e2a9f
When marking a task dirty:
Closes PACK-2846