Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing import map description in resolving issue when there is no import map mapping #7830

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 24, 2024

Description

Avoid showing import map description in resolving issue when there is no import map mapping

Testing Instructions

Closes PACK-2828

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 8:38am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 8:38am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 8:38am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 8:38am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 8:38am

Copy link
Contributor

github-actions bot commented Mar 24, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Mar 24, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 24, 2024

🟢 CI successful 🟢

Thanks

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I updated jest snapshots while merging vercel/next.js#63541

The relevant snapshot changes will need some modfications

@sokra sokra merged commit 81ff817 into main Mar 25, 2024
50 checks passed
@sokra sokra deleted the sokra/no-import-map branch March 25, 2024 10:32
timneutkens pushed a commit to vercel/next.js that referenced this pull request Mar 27, 2024
* vercel/turborepo#7797 <!-- Tobias Koppers - fix
externals in side-effect optimized modules -->
* vercel/turborepo#7830 <!-- Tobias Koppers - Avoid
showing import map description in resolving issue when there is no
import map mapping -->
* vercel/turborepo#7833 <!-- Tobias Koppers - add
next.js trace format -->
* vercel/turborepo#7835 <!-- Tobias Koppers -
correct global start by first start time -->
* vercel/turborepo#7812 <!-- Will Binns-Smith -
Turbopack docs: Fix broken webpack loaders link -->
* vercel/turborepo#7847 <!-- Will Binns-Smith -
Turbo tasks: Reuse aggregation context and apply queued updates -->
* vercel/turborepo#7840 <!-- Tobias Koppers - add
concurrency corrected duration -->
* vercel/turborepo#7854 <!-- Tobias Koppers - fix
size_hint on count hash set -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
… no import map mapping (vercel/turborepo#7830)

### Description

Avoid showing import map description in resolving issue when there is no
import map mapping

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2828
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
… no import map mapping (vercel/turborepo#7830)

### Description

Avoid showing import map description in resolving issue when there is no
import map mapping

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2828
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
… no import map mapping (vercel/turborepo#7830)

### Description

Avoid showing import map description in resolving issue when there is no
import map mapping

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2828
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
… no import map mapping (vercel/turborepo#7830)

### Description

Avoid showing import map description in resolving issue when there is no
import map mapping

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants