-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid showing import map description in resolving issue when there is no import map mapping #7830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no import map mapping
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
✅ This change can build |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
kwonoj
approved these changes
Mar 24, 2024
timneutkens
approved these changes
Mar 24, 2024
kdy1
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I updated jest snapshots while merging vercel/next.js#63541
The relevant snapshot changes will need some modfications
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 27, 2024
* vercel/turborepo#7797 <!-- Tobias Koppers - fix externals in side-effect optimized modules --> * vercel/turborepo#7830 <!-- Tobias Koppers - Avoid showing import map description in resolving issue when there is no import map mapping --> * vercel/turborepo#7833 <!-- Tobias Koppers - add next.js trace format --> * vercel/turborepo#7835 <!-- Tobias Koppers - correct global start by first start time --> * vercel/turborepo#7812 <!-- Will Binns-Smith - Turbopack docs: Fix broken webpack loaders link --> * vercel/turborepo#7847 <!-- Will Binns-Smith - Turbo tasks: Reuse aggregation context and apply queued updates --> * vercel/turborepo#7840 <!-- Tobias Koppers - add concurrency corrected duration --> * vercel/turborepo#7854 <!-- Tobias Koppers - fix size_hint on count hash set -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
… no import map mapping (vercel/turborepo#7830) ### Description Avoid showing import map description in resolving issue when there is no import map mapping ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2828
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
… no import map mapping (vercel/turborepo#7830) ### Description Avoid showing import map description in resolving issue when there is no import map mapping ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2828
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
… no import map mapping (vercel/turborepo#7830) ### Description Avoid showing import map description in resolving issue when there is no import map mapping ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2828
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
… no import map mapping (vercel/turborepo#7830) ### Description Avoid showing import map description in resolving issue when there is no import map mapping ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid showing import map description in resolving issue when there is no import map mapping
Testing Instructions
Closes PACK-2828