-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect output mode 'none' even when caching is disabled #7900
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@aholland is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Please open an issue with the |
Hey, sorry, for not getting this in before! CI hung on some stale check so the auto-merge didn't go through. Now with the 2.0 release, this changed names. @aholland, would you be able to update it? |
Description
Suppose I have some pipline like this:
The
outputMode
is ignored because ofcache
being false. That's annoying. I don't want to see myrm -rf
running every time I do I build, including builds where all the rest of the tasks are cached (I tend to usenew-only
for most other tasks).Testing Instructions
I am not a Rust programmer but I think I have found the place that would need to be changed. To test the change, just create any simple package.son task that generates output (
"echo": "echo \"hello world\"",
) and run it from a TurboRepo task with caching false and outMode none, as above.PS
errors-only
PS having absolutely no output would be okay. Even better would be an implementation of errors-only, outputting one line saying that the task has been executed because it is set not to cache, and that it executed successfully. I think that would involve something like the below code (copied from about line 195 of the same file I've modified in this PR), but again, I don't know Rust or your codebase: