feat: support interop for namespace importing cjs function exports #7914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
|
ForsakenHarmony
force-pushed
the
hrmny/pack-2916-interop-function-exports
branch
from
bcfffe7
to
bc6a780
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2916-interop-function-exports
branch
from
bc6a780
to
058c317
Compare
ForsakenHarmony
force-pushed
the
hrmny/pack-2916-interop-function-exports
branch
from
058c317
to
3290368
Compare
sokra
approved these changes
Apr 9, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 9, 2024
* vercel/turborepo#7912 <!-- Tobias Koppers - fix edge condition in environment --> * vercel/turborepo#7914 <!-- hrmny - feat: support interop for namespace importing cjs function exports -->
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…ercel/turborepo#7914) ### Description Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies. `a.js` ```js module.exports = () => {}; ``` `b.js` ```js import * as ns from "./a.cjs"; ns(); ```
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7914) ### Description Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies. `a.js` ```js module.exports = () => {}; ``` `b.js` ```js import * as ns from "./a.cjs"; ns(); ```
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#7914) ### Description Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies. `a.js` ```js module.exports = () => {}; ``` `b.js` ```js import * as ns from "./a.cjs"; ns(); ```
ForsakenHarmony
added a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…ercel/turborepo#7914) ### Description Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies. `a.js` ```js module.exports = () => {}; ``` `b.js` ```js import * as ns from "./a.cjs"; ns(); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies.
a.jsb.js