Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbopack-ecmascript): use direct namespace re-export #7963

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix(turbopack-ecmascript): use direct namespace re-export #7963

merged 3 commits into from
Apr 15, 2024

Conversation

ForsakenHarmony
Copy link
Member

@ForsakenHarmony ForsakenHarmony commented Apr 15, 2024 •
edited
Loading

Description

Also has a fix for async modules with __turbopack_export_namespace__.

Could still break if __turbopack_export_namespace__ is called before an await.

Closes PACK-2962

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:34pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:34pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:34pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:34pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 5:34pm

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review April 15, 2024 16:31
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner April 15, 2024 16:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 984a635 into main Apr 15, 2024
45 of 47 checks passed
@sokra sokra deleted the hrmny/fix-external-re-export branch April 15, 2024 17:57
@sokra sokra mentioned this pull request Apr 15, 2024
Merged
ForsakenHarmony added a commit that referenced this pull request Apr 15, 2024
@ForsakenHarmony
Revert "fix(turbopack-ecmascript): use direct namespace re-export (#7963
4dafbec 
)"

This reverts commit 984a635.
@ForsakenHarmony ForsakenHarmony mentioned this pull request Apr 15, 2024
Merged
sokra pushed a commit that referenced this pull request Apr 15, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
f91c908 
…per (#7742)" (#7969)

### Description

Reverts #7742 #7961 #7963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ForsakenHarmony @sokra