Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(turbopack-ecmascript): cache external modules with wrapper (#7742)" #7969

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Revert "feat(turbopack-ecmascript): cache external modules with wrapper (#7742)" #7969

merged 3 commits into from
Apr 15, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

Description

Reverts #7742 #7961 #7963

@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner April 15, 2024 18:29
@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 15, 2024 6:38pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 6:38pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Apr 15, 2024 6:38pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-native-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 15, 2024 6:38pm

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit f91c908 into main Apr 15, 2024
48 of 51 checks passed
@sokra sokra deleted the revert-7742-hrmny-pack-2622-cache-external-modules-during-evaluation branch April 15, 2024 19:38
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
58eab89 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
6a406fb 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
679c73a 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
a188c77 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForsakenHarmony @sokra