Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mdx): support custom parse construct options #8005

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat(mdx): support custom parse construct options #8005

merged 1 commit into from
Apr 19, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 19, 2024 •
edited by padmaia
Loading

Description

Part 1 for PACK-2978, extending & consolidating existing mdx transform options to support partial set of parse / transform options. Notably to support construct between gfm vs commonmark.

Closes PACK-2979

@kwonoj kwonoj requested a review from a team as a code owner April 19, 2024 21:05
@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 19, 2024 9:14pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 9:14pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-native-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 19, 2024 9:14pm

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=9f7ab27da381aa4d6c8c815d4c62c1fee704034c#c622d671)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.33` are: 0.90.36, 0.90.35, 0.90.34, 0.90.33

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.30`
    ... which satisfies dependency `swc_core = "^0.90.30"` (locked to 0.90.30) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj mentioned this pull request Apr 19, 2024
Merged
@kwonoj kwonoj merged commit 9bb156a into main Apr 19, 2024
47 of 50 checks passed
@kwonoj kwonoj deleted the feat-mdx-options branch April 19, 2024 21:54
kwonoj added a commit that referenced this pull request Apr 19, 2024
@kwonoj
Revert "feat(mdx): support custom parse construct options (#8005)"
a31899e 
This reverts commit 9bb156a.
@kwonoj kwonoj mentioned this pull request Apr 19, 2024
Merged
kwonoj added a commit that referenced this pull request Apr 19, 2024
@kwonoj
Revert "feat(mdx): support custom parse construct options" (#8008)
e3e52e7 
Reverts #8005

Closes PACK-2980
@kwonoj kwonoj mentioned this pull request Apr 22, 2024
Closed
kwonoj added a commit to vercel/next.js that referenced this pull request Apr 22, 2024
@kwonoj
fext(next): extend next.config for mdxRs support options (#64801)
372f00e 
### What

Closes PACK-2978, requires vercel/turbo#8005.

PR extends existing mdxRs config from accepting object as well in
addition to current boolean flag, mainly to allow to specify what kind
of markdown types will be used between gfm and commonmark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwonoj @wbinnssmith