Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(mdx): support custom parse construct options" #8008

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Revert "feat(mdx): support custom parse construct options" #8008

merged 1 commit into from
Apr 19, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Apr 19, 2024 •
edited by padmaia

Reverts #8005

Closes PACK-2980

@kwonoj kwonoj requested a review from a team as a code owner April 19, 2024 23:37
@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:48pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:48pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:48pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 11:48pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:48pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:48pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 19, 2024 11:48pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:48pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:48pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 11:48pm

@linear Linear
Copy link

linear bot commented Apr 19, 2024

Issue reopened: PACK-2979 feat(mdx): support custom parse construct options

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=75efcdd762690b8503c4467208a5d29cb9f5de67#9bb156a6)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.33` are: 0.90.36, 0.90.35, 0.90.34, 0.90.33

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.30`
    ... which satisfies dependency `swc_core = "^0.90.30"` (locked to 0.90.30) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@kwonoj kwonoj merged commit e3e52e7 into main Apr 19, 2024
43 of 46 checks passed
@kwonoj kwonoj deleted the revert-8005-feat-mdx-options branch April 19, 2024 23:39
kwonoj added a commit that referenced this pull request Apr 19, 2024
@kwonoj
Revert "Revert "feat(mdx): support custom parse construct options" (#…
ecff9f8 
…8008)"

This reverts commit e3e52e7.
@kwonoj kwonoj mentioned this pull request Apr 19, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 19, 2024 •
edited

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kwonoj kwonoj mentioned this pull request Apr 22, 2024
Closed
kwonoj added a commit that referenced this pull request Apr 22, 2024
@kwonoj
Revert "Revert "feat(mdx): support custom parse construct options" (#…
1e77f6c 
…8008)"

This reverts commit e3e52e7.
kwonoj added a commit that referenced this pull request Apr 22, 2024
@kwonoj
Revert "Revert "feat(mdx): support custom parse construct options" (#…
98eb6b0 
…8008)"

This reverts commit e3e52e7.
kwonoj added a commit that referenced this pull request Apr 22, 2024
@kwonoj
feat(mdx): support custom parse construct options (#8009)
ca565a7 
Reverts #8008

Closes PACK-2981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: turbopack owned-by: turbopack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kwonoj