feat: Improve error messages from mdxrs
#8031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
|
✅ This change can build |
arlyon
reviewed
May 21, 2024
| let (start, end) = match *p { | ||
| markdown::message::Place::Position(p) => ( | ||
| SourcePos { | ||
| line: p.start.line, |
There was a problem hiding this comment.
I know there is sometimes disagreement between 0 or 1 indexed line numbers, might be handy to have a comment here for later reference
arlyon
approved these changes
May 21, 2024
|
I'll retry in the future |
sokra
pushed a commit
that referenced
this pull request
Jul 31, 2024
Trying #8031 again ~~Depends on #8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 31, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Trying vercel/turborepo#8031 again ~~Depends on vercel/turborepo#8766 <img width="979" alt="Bildschirmfoto 2024-07-30 um 15 35 48" src="https://github.com/user-attachments/assets/32d88ffc-c816-41fb-928b-79d27e89b56d"> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve error messages from mdxrs
Closes PACK-2589
Testing Instructions
next.js counterpart: vercel/next.js#64953