feat: Add lint for grid-template-areas
#8060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
sokra
reviewed
Apr 30, 2024
sokra
reviewed
Apr 30, 2024
sokra
reviewed
Apr 30, 2024
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
sokra
approved these changes
May 8, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 8, 2024
* vercel/turborepo#8073 <!-- OJ Kwon - feat(webpack-loaders): support dummy span interface --> * vercel/turborepo#8083 <!-- OJ Kwon - fix(webpack): print resource, project path when relative calc fails --> * vercel/turborepo#8094 <!-- Tim Neutkens - Implement bindings for Turbopack trace server --> * vercel/turborepo#8061 <!-- Tobias Koppers - reduce memory usage in analyser --> * vercel/turborepo#8077 <!-- Alexander Lyon - Remove async-trait from a few crates --> * vercel/turborepo#8102 <!-- Tobias Koppers - fix memory counting without custom allocator --> * vercel/turborepo#8096 <!-- Benjamin Woodruff - turbo-tasks: Expand `<T as TaskOutput>::Return` values in macros --> * vercel/turborepo#8105 <!-- Benjamin Woodruff - turbopack-node: Use path.join for postcss loader --> * vercel/turborepo#8099 <!-- Tim Neutkens - Replace websocket with tungstenite for turbo-trace-server --> * vercel/turborepo#8060 <!-- Donny/강동윤 - feat: Add lint for `grid-template-areas` --> * vercel/turborepo#8110 <!-- Tobias Koppers - fix lockfile -->
kdy1
added a commit
that referenced
this pull request
May 23, 2024
Reverts #8060 parcel-bundler/lightningcss#739 is now applied so we don't need this lint anymore
Neosoulink
pushed a commit
to Neosoulink/turbo
that referenced
this pull request
Jun 14, 2024
### Description > grid-template-areas and grid-area behaves differently in lightningcss and that leads to some user problems, so we need a check to catches these errors. > Since lightning css in css modules is renaming grid area names, you have to use grid-area and grid-template-areas in the same file together. Using them in different files would be an error. > > So it would be great to have a check that emits an error when using grid-area in a CSS file but not declaring the name in grid-template-areas. Closes PACK-3022 ### Testing Instructions I added some tests --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description > grid-template-areas and grid-area behaves differently in lightningcss and that leads to some user problems, so we need a check to catches these errors. > Since lightning css in css modules is renaming grid area names, you have to use grid-area and grid-template-areas in the same file together. Using them in different files would be an error. > > So it would be great to have a check that emits an error when using grid-area in a CSS file but not declaring the name in grid-template-areas. Closes PACK-3022 ### Testing Instructions I added some tests --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
Reverts vercel/turborepo#8060 parcel-bundler/lightningcss#739 is now applied so we don't need this lint anymore
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description > grid-template-areas and grid-area behaves differently in lightningcss and that leads to some user problems, so we need a check to catches these errors. > Since lightning css in css modules is renaming grid area names, you have to use grid-area and grid-template-areas in the same file together. Using them in different files would be an error. > > So it would be great to have a check that emits an error when using grid-area in a CSS file but not declaring the name in grid-template-areas. Closes PACK-3022 ### Testing Instructions I added some tests --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Reverts vercel/turborepo#8060 parcel-bundler/lightningcss#739 is now applied so we don't need this lint anymore
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description > grid-template-areas and grid-area behaves differently in lightningcss and that leads to some user problems, so we need a check to catches these errors. > Since lightning css in css modules is renaming grid area names, you have to use grid-area and grid-template-areas in the same file together. Using them in different files would be an error. > > So it would be great to have a check that emits an error when using grid-area in a CSS file but not declaring the name in grid-template-areas. Closes PACK-3022 ### Testing Instructions I added some tests --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Reverts vercel/turborepo#8060 parcel-bundler/lightningcss#739 is now applied so we don't need this lint anymore
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description > grid-template-areas and grid-area behaves differently in lightningcss and that leads to some user problems, so we need a check to catches these errors. > Since lightning css in css modules is renaming grid area names, you have to use grid-area and grid-template-areas in the same file together. Using them in different files would be an error. > > So it would be great to have a check that emits an error when using grid-area in a CSS file but not declaring the name in grid-template-areas. Closes PACK-3022 ### Testing Instructions I added some tests --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Reverts vercel/turborepo#8060 parcel-bundler/lightningcss#739 is now applied so we don't need this lint anymore
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8073 <!-- OJ Kwon - feat(webpack-loaders): support dummy span interface --> * vercel/turborepo#8083 <!-- OJ Kwon - fix(webpack): print resource, project path when relative calc fails --> * vercel/turborepo#8094 <!-- Tim Neutkens - Implement bindings for Turbopack trace server --> * vercel/turborepo#8061 <!-- Tobias Koppers - reduce memory usage in analyser --> * vercel/turborepo#8077 <!-- Alexander Lyon - Remove async-trait from a few crates --> * vercel/turborepo#8102 <!-- Tobias Koppers - fix memory counting without custom allocator --> * vercel/turborepo#8096 <!-- Benjamin Woodruff - turbo-tasks: Expand `<T as TaskOutput>::Return` values in macros --> * vercel/turborepo#8105 <!-- Benjamin Woodruff - turbopack-node: Use path.join for postcss loader --> * vercel/turborepo#8099 <!-- Tim Neutkens - Replace websocket with tungstenite for turbo-trace-server --> * vercel/turborepo#8060 <!-- Donny/강동윤 - feat: Add lint for `grid-template-areas` --> * vercel/turborepo#8110 <!-- Tobias Koppers - fix lockfile -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes PACK-3022
Testing Instructions
I added some tests