Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory counting without custom allocator #8102

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented May 7, 2024

Description

Testing Instructions

Closes PACK-3044

@sokra sokra requested a review from a team as a code owner May 7, 2024 14:28
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:49pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:49pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:49pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:49pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:49pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:49pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:49pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:49pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:49pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:49pm

Copy link
Contributor

github-actions bot commented May 7, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 7, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented May 7, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member

@ForsakenHarmony ForsakenHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the PR title be "with custom allocator"?

@sokra sokra merged commit e23c445 into main May 7, 2024
47 of 50 checks passed
@sokra sokra deleted the sokra/fix-memory-counting branch May 7, 2024 16:33
sokra added a commit to vercel/next.js that referenced this pull request May 8, 2024
* vercel/turbo#8073 <!-- OJ Kwon -
feat(webpack-loaders): support dummy span interface -->
* vercel/turbo#8083 <!-- OJ Kwon - fix(webpack):
print resource, project path when relative calc fails -->
* vercel/turbo#8094 <!-- Tim Neutkens -
Implement bindings for Turbopack trace server -->
* vercel/turbo#8061 <!-- Tobias Koppers - reduce
memory usage in analyser -->
* vercel/turbo#8077 <!-- Alexander Lyon - Remove
async-trait from a few crates -->
* vercel/turbo#8102 <!-- Tobias Koppers - fix
memory counting without custom allocator -->
* vercel/turbo#8096 <!-- Benjamin Woodruff -
turbo-tasks: Expand `<T as TaskOutput>::Return` values in macros -->
* vercel/turbo#8105 <!-- Benjamin Woodruff -
turbopack-node: Use path.join for postcss loader -->
* vercel/turbo#8099 <!-- Tim Neutkens - Replace
websocket with tungstenite for turbo-trace-server -->
* vercel/turbo#8060 <!-- Donny/강동윤 - feat: Add
lint for `grid-template-areas` -->
* vercel/turbo#8110 <!-- Tobias Koppers - fix
lockfile -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants